feat!: update gks-common / vrs models #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ebca83.
korikuzma
added
enhancement
toneillbroad
approved these changes
Oct 29, 2024
jsstevenson
approved these changes
Oct 29, 2024
toneillbroad
approved these changes
Oct 29, 2024
|
Sorry... now I'm done |
jsstevenson
reviewed
Oct 30, 2024
| @@ -25,7 +25,7 @@ class GKSSchemaMapping(BaseModel): | |||
| base_classes: set = set() | |||
| concrete_classes: set = set() | |||
| primitives: set = set() | |||
| schema: dict = dict() | |||
| schema: dict = {} | |||
There was a problem hiding this comment.
as a side note, I tried to properly add ruff to vrs-python a few months ago, but the import sort ended up introducing a circular dependency. If it's not doing that anymore, then we could probably get it added in.
There was a problem hiding this comment.
@jsstevenson ah, I don't have ruff added to VRS-Python. I noticed this when working in Cat-VRS-Python, which does have ruff installed.
jsstevenson
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #452