Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmRearrange -tile -r -mn 3 -maximize 0 0 #1107

Closed
rasatpc opened this issue Nov 12, 2024 · 15 comments
Closed

FvwmRearrange -tile -r -mn 3 -maximize 0 0 #1107

rasatpc opened this issue Nov 12, 2024 · 15 comments
Assignees
Labels
relates:module Issue is in module code skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Milestone

Comments

@rasatpc
Copy link

rasatpc commented Nov 12, 2024

  • Fvwm3 version (run: fvwm3 --version)
    fvwm3 1.1.1 (1.1.0-120-g3e0d960d)

Behaviour

Tile windows into columns and rows.
FvwmRearrange -tile -r -mn 3 -maximize 0 0 86 82

Does not work when numbers are added to maximize. Without numbers, it places all windows into columns without rows.
FvwmRearrange -tile -r -mn 3 -maximize

@rasatpc rasatpc added the type:bug Something's broken! label Nov 12, 2024
@ThomasAdam ThomasAdam added the relates:module Issue is in module code label Nov 12, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Nov 12, 2024
@ThomasAdam ThomasAdam added this to FVWM3 Nov 12, 2024
@github-project-automation github-project-automation bot moved this to To do in FVWM3 Nov 12, 2024
@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

Read the manual page, the options and behavior of FvwmRearrange has been drastically changed. The single letter options no longer exist.

@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

FvwmRearrnage -tile -reverse -max_n 3 -maximize 0 0 86 82 works just fine for me. Though you may want to check out the new features.

@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

The issue is -mn is no longer an option, so the number in -mn 3 is read as part of the bounding box, so the bounding box is then used to be 3 0 0 86 which won't do anything. The bounding box logic has always been a bit fragile this way, this isn't new, what is new is the options have changed so the old options will cause odd issues.

@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Nov 12, 2024
@ThomasAdam ThomasAdam closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in FVWM3 Nov 12, 2024
@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

FvwmRearrnage -tile -reverse -max_n 3 -maximize 0 0 86 82

Testing with default config, doesn't work. Manpage examples, only FvwmRearrange -cascade 10 2 80 70 works. Additional options with -tile don't work.

@ThomasAdam
Copy link
Member

@rasatpc

Are you saying there's something in the default config which references FvwmRearrange which doesn't work (i.e, a configuration problem), or something else?

Again, you need to take into account the changes made to FvwmRearrange as breaking.

@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

The default config is fine. I am testing the different FvwmRearrange examples in the manpage.

@ThomasAdam
Copy link
Member

OK. When you actually have something which might be an issue, let us know. Until then, please try and not muddy the waters.

@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

The issue is that option -tile does not work. Option -cascade is ok.

@ThomasAdam
Copy link
Member

But it has always been that way, @rasatpc -- that's not anything new. They're mutually-exclusive.

@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

It worked fine until recent updates. I have been using option -tile for a long time.

https://www.fvwm.org/Wiki/Modules/FvwmRearrange/

@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

The wiki has not been updated, use the man page. What do you mean the option '-tile' does not work, in my tests it does what it is designed to do.

@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

What do you mean the option '-tile' does not work

I tried many options mentioned in the FvwmRearrange manpage. Some work, others not. Here is the list:

FvwmRearrange -tile -swap 10 10 90 90 (ok)
----
FvwmRearrange -tile -swap 0 0 35 100
FvwmRearrange 35 0 100 10
(ok)
-----
FvwmRearrnage -tile -swap -max_n 3 0 0 86 82 (no)
FvwmRearrnage -tile -max_n 3 0 0 86 82 (no)
FvwmRearrnage -auto_tile (no)
FvwmRearrnage -tile -reverse -max_n 3 0 0 86 82 (no)

Option -maximize is not mentioned in the manpage. I did a test and got my code to work with minor edits.
FvwmRearrange -tile -reverse -max_n 3 -maximize 0 0 86 82 (ok)

@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

You have not clarified what doesn't work is doing. Also you should search the manual page better, -maximize is in the manual page.

Of course FvwmRearrnage -tile -swap -max_n 3 0 0 86 82 doesn't work, but if you spell FvwmRearrange correctly it does work.

@rasatpc
Copy link
Author

rasatpc commented Nov 12, 2024

somiaj: FvwmRearrnage -tile -reverse -max_n 3 -maximize 0 0 86 82 works just fine for me

I copied your spelling error. :) With the correction, everything works fine. Also, I found the option -maximize.

@somiaj
Copy link
Collaborator

somiaj commented Nov 12, 2024

Ahh sorry, silly me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:module Issue is in module code skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
Status: Done
Development

No branches or pull requests

3 participants