Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer3 should accept a variant lookup Path #53

Open
msto opened this issue Sep 30, 2024 · 3 comments · May be fixed by #62
Open

Primer3 should accept a variant lookup Path #53

msto opened this issue Sep 30, 2024 · 3 comments · May be fixed by #62
Assignees

Comments

@msto
Copy link
Collaborator

msto commented Sep 30, 2024

Much like Primer3 accepts a Path to the input FASTA, it would be more ergonomic if the class accepted a Path to a VCF instead of requiring the user to construct a VariantLookup.

@emmcauley
Copy link
Collaborator

We have two VariantLookup objects and corresponding constructors: one is recommended for smaller VCFs and one is recommended for bigger VCFs. I'm envisioning that we could take a path to a VCF, determine the appropriate constructor, and construct the VariantLookup object under the hood.

@msto:
-do you agree with my thoughts above? Did I miss anything?
-if so, what do you think is the best way for us to check the given VCF path to see which constructor would be the appropriate one to call?

@emmcauley
Copy link
Collaborator

plan:

  • add to the Primer3 constructor, a list of VCFs, and a boolean flag (should we load into memory or query every time we need something?) -- the bool will trigger what variant lookup to build; but the default will be the disk-based one

@msto
Copy link
Collaborator Author

msto commented Oct 3, 2024

Yes, that's exactly what I had in mind 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants