Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not centered #3

Open
TheLastGimbus opened this issue Jun 16, 2023 · 3 comments
Open

Icons are not centered #3

TheLastGimbus opened this issue Jun 16, 2023 · 3 comments

Comments

@TheLastGimbus
Copy link

Hi!

I love this library so much!! One small problem i have is that all icons are bit to the bottom 😕

image

@fujidaiti
Copy link
Owner

fujidaiti commented Jun 17, 2023

I think this is the same problem as reported in the flutter repo. I can't think of a solution, but it should be fixed when Symbols are officially supported.

Thanks for using this package. However, I personally recommend using this package instead, which is 100% compatible with the official API that will be released in a future release of Flutter and supports the tree shaking. I believe this package has already solved this problem.

@TheLastGimbus
Copy link
Author

TheLastGimbus commented Jun 17, 2023

Okay, so you kinda abondoned your package in favor of this other? Oh, okay... maybe add this info to readme

Thanks for help!!

Ps. Does tree shaking work for android as well? I really liked how your package gave me only iconsci cared about...

@fujidaiti
Copy link
Owner

Ps. Does tree shaking work for android as well?

Yes! You can confirm that by building an apk like:

$flutter build apk

Font asset "MaterialIcons-Regular.otf" was tree-shaken, reducing it from 1645184 to 1256 bytes (99.9% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Font asset "CupertinoIcons.ttf" was tree-shaken, reducing it from 283452 to 1208 bytes (99.6% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Font asset "MaterialSymbolsSharp[FILL,GRAD,opsz,wght].ttf" was tree-shaken, reducing it from 6292356 to 2344 bytes (100.0% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Font asset "MaterialSymbolsOutlined[FILL,GRAD,opsz,wght].ttf" was tree-shaken, reducing it from 7531160 to 5184 bytes (99.9% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Font asset "MaterialSymbolsRounded[FILL,GRAD,opsz,wght].ttf" was tree-shaken, reducing it from 10221712 to 2664 bytes (100.0% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Running Gradle task 'assembleRelease'...                           41.2s
✓  Built build/app/outputs/flutter-apk/app-release.apk (16.6MB).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants