Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update star-citizen: 2.0.5 -> 2.0.6 #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LovingMelody
Copy link
Contributor

@LovingMelody LovingMelody commented Nov 4, 2024

  • Bump launcher version to 2.0.6

  • Add work around for java script error

fixes #206

@LovingMelody
Copy link
Contributor Author

@damccull can you test if this fixes your issue?

@damccull
Copy link

damccull commented Nov 6, 2024

@damccull can you test if this fixes your issue?

Yes, I would love to. How do I target this PR to install this version as a test? I'm still learning nixos, and using a flake. Do I just set the input to github and point at this PR specifically?

@fufexan
Copy link
Owner

fufexan commented Nov 6, 2024

@damccull change the nix-gaming input url to github:LovingMelody/nix-gaming/update-star-citizen, and rebuild.

@LovingMelody
Copy link
Contributor Author

Force push changes:

  • Updated dll overrides to prevent wine from creating desktop icons
  • Set WINEDEBUG=-all to reduce wine debug messages

* Bump launcher version to 2.0.6

* Add work arround for a known javascript error when launching from an
  application. Details can be found on spectrum:
  https://robertsspaceindustries.com/spectrum/community/SC/forum/1/thread/upcoming-launcher-update-for-linux-users/5693728

* Set default dll override to disable menubuilding to prevent wine from
  creating uneeded desktop shortcuts

* Set environment variable `WINEDEBUG=-all` to reduce console debug
  messages
@LovingMelody
Copy link
Contributor Author

Updated packaged to use a cleaner work around. I have tested with systemd-run --user -d -- nix run .\#star-citizen to ensure the issue isnt present still.

@damccull
Copy link

damccull commented Nov 7, 2024

I have changed to the repo you mentioned, and even rebooted. Still, typing star-citizen in the terminal will launch it fine but I get the same issue when clicking the shortcut in the apps menu.

@damccull change the nix-gaming input url to github:LovingMelody/nix-gaming/update-star-citizen, and rebuild.

@LovingMelody
Copy link
Contributor Author

What desktop environment are you using?

@damccull
Copy link

damccull commented Nov 7, 2024

What desktop environment are you using?

Good question that I hadn't considered. It is the default that NixOS seems to use. Gnome on Wayland I believe.

Thanks for being patient with me. I'm familiar with Linux in a server context but I'm still adjusting to 20+ years of Windows use for a desktop environment.

@LovingMelody
Copy link
Contributor Author

Hmm, it should be using systemd-run, I will have to look further into this. The umu variant shouldn't have this problem if you wish to try it.

@LovingMelody
Copy link
Contributor Author

@damccull what branch of nixpkgs are you on (ideally the commit as well)?

@damccull
Copy link

I am currently using nixos-unstable, and my flake.lock says.... (drumroll)

    "nixpkgs": {
      "locked": {
        "lastModified": 1718714799,
        "narHash": "sha256-FUZpz9rg3gL8NVPKbqU8ei1VkPLsTIfAJ2fdAf5qjak=",
        "owner": "nixos",
        "repo": "nixpkgs",
        "rev": "c00d587b1a1afbf200b1d8f0b0e4ba9deb1c7f0e",
        "type": "github"
      },
      "original": {
        "owner": "nixos",
        "ref": "nixos-unstable",
        "repo": "nixpkgs",
        "type": "github"
      }
    },

This is what you wondered? I update every couple weeks but this is what I last tried it on and am currently running.

@LovingMelody
Copy link
Contributor Author

I cannot recreate your issue with this pr, I can on master.

@damccull
Copy link

Ok, I'll do a complete SC wipe and reinstall, including deleting the Wine folder, removing it from the config, running nix garbage collector. I'll also do an update of NixOS. Then I'll reinstall this PR and let you know what happens. I have no worries on bandwidth so I am happy to download the game again.

@LovingMelody
Copy link
Contributor Author

Shouldn't require reinstalling the game. Just ensure your flake input is targeting the update-star-citizen branch

@damccull
Copy link

I agree with you, but I did do that and nothing changed. So I'm going the nuclear route just to ensure there's nothing weird going on in my system. I've already begun, but it won't be a long process.

@damccull
Copy link

Well, this fixed it. Not sure what it was holding it back. Shortcut is working fine now. I wonder if it was just my shortcut that was jacked up. Either way, thank you for the effort in fixing this.

@damccull
Copy link

damccull commented Nov 13, 2024

Would you mind telling me what was causing the problem so I can learn a bit more about wine and nix? Difficult to figure out just from the changes.

@LovingMelody
Copy link
Contributor Author

the launcher cant handle the logs outputting to the journal (which is what the desktop shortcut does on gnome, it uses systemd-run) this is just a work around for that by checking if the command is run from the terminal and if it isn't, route the output to a file.
Proton gets around this through other means: ValveSoftware/wine@4703b10

@damccull
Copy link

How weird. I didn't think it would care where the logs go. Thanks for the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken launcher from .desktop file
3 participants