Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu-lazer-bin: use overrideAttrs with nixpkgs' package #152

Closed
wants to merge 4 commits into from

Conversation

Guanran928
Copy link

@Guanran928 Guanran928 commented Feb 8, 2024

Motivation: #137 (comment)

Still experimental, don't expect anything, commits will be squashed when ready to merge.

In the long-term, it might be worthwhile to just override Nixpkgs' package definition, though it might not be trivial since the Nixpkgs' package is conditional and depends on architecture and OS.

I just made a overrideAttrs version of osu-stable-bin and somehow made the update script working.
It's not perfect, but it works for me.
I don't really know anything about bash, so I probably need someone that knows bash to help me a little bit.

@Guanran928 Guanran928 marked this pull request as draft February 8, 2024 11:19
@Guanran928
Copy link
Author

Guanran928 commented Feb 8, 2024

LOL, I published the PR too soon, I downgraded nixpkgs and it isn't even working properly, will fix.

image

@Guanran928 Guanran928 closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant