From 8334c5ca174568fd5989878ef9ce0690128bf873 Mon Sep 17 00:00:00 2001
From: Melody Renata <me@lovingmelody.io>
Date: Mon, 4 Nov 2024 16:03:46 -0500
Subject: [PATCH] Update star-citizen: 2.0.5 -> 2.0.6

* Bump launcher version to 2.0.6

* Add cli-mode option (enabled by default for non-umu)
  This is added to prevent a known javascript error
  This adds `Terminal = true` to the desktop shortcut
  Details can be found on spectrum:
  https://robertsspaceindustries.com/spectrum/community/SC/forum/1/thread/upcoming-launcher-update-for-linux-users/5693728

* Set default dll override to disable menubuilding to prevent wine from
  creating uneeded desktop shortcuts

* Set environment variable `WINEDEBUG=-all` to reduce console debug
  messages
---
 pkgs/star-citizen/default.nix | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/pkgs/star-citizen/default.nix b/pkgs/star-citizen/default.nix
index c09386f9..730e4fb6 100644
--- a/pkgs/star-citizen/default.nix
+++ b/pkgs/star-citizen/default.nix
@@ -17,22 +17,23 @@
   useUmu ? false,
   protonPath ? "${proton-ge-bin.steamcompattool}/",
   protonVerbs ? ["waitforexitandrun"],
-  wineDllOverrides ? [],
+  wineDllOverrides ? ["winemenubuilder.exe=d"],
   gameScopeEnable ? false,
   gameScopeArgs ? [],
   preCommands ? "",
   postCommands ? "",
   enableGlCache ? true,
   glCacheSize ? 1073741824,
+  cli-mode ? ! useUmu,
   pkgs,
 }: let
   inherit (lib.strings) concatStringsSep optionalString;
   # Latest version can be found: https://install.robertsspaceindustries.com/rel/2/latest.yml
-  version = "2.0.5";
+  version = "2.0.6";
   src = pkgs.fetchurl {
     url = "https://install.robertsspaceindustries.com/rel/2/RSI%20Launcher-Setup-${version}.exe";
     name = "RSI Launcher-Setup-${version}.exe";
-    hash = "sha256-NevMkWdXe3aKFUqBgI32nshp0qZ8c4nSJ1qdV3EGpGk=";
+    hash = "sha256-r/Ui523LcWaIE5DycH7YJcFQiHKmz1gxdXILBUqVQm4=";
   };
 
   # Powershell stub for star-citizen
@@ -63,6 +64,7 @@
         export WINE_HIDE_NVIDIA_GPU=1
         # AMD
         export dual_color_blend_by_location="true"
+        export WINEDEBUG=-all
 
       ''
     }
@@ -145,6 +147,9 @@
     desktopName = "Star Citizen";
     categories = ["Game"];
     mimeTypes = ["application/x-star-citizen-launcher"];
+    # This is needed to prevent the JavaScript error
+    # https://github.com/starcitizen-lug/knowledge-base/wiki/Troubleshooting#rsi-launcher-v162-javascript-error
+    terminal = cli-mode;
   };
 in
   symlinkJoin {