Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package dev tools #98

Closed
ap-- opened this issue Apr 26, 2023 · 4 comments
Closed

Updating package dev tools #98

ap-- opened this issue Apr 26, 2023 · 4 comments

Comments

@ap--
Copy link
Collaborator

ap-- commented Apr 26, 2023

from #96

  • Migrate to hatch, stop using legacy setup metadata format.
  • Update and consolidate dev tools and test dependencies.
  • New nox tasks and minor changes for convenience.
  • Add, configure, and apply pre-commit for consistent code formatting.

@brl0, I'm all for this. It might be worth to wait for fsspec/community#6 (and https://github.com/fsspec/cookiecutter-fsspec) to be ready, so that we don't have to do this twice.

I would almost say, let's wait for either the template to be ready, or Python3.12 to be available as a release candidate and whatever is first, will trigger this refactor.

But I have no strong opinion here.

@brl0
Copy link
Contributor

brl0 commented Apr 26, 2023

@ap--,

I had previously made these changes in a branch and just need to separate them out. I can certainly skip them if it would just create pointless extra maintenance burden, but hopefully the changes are reasonable and helpful. I appreciate and respect your time and effort, so I am happy to defer to your opinion. For now, I'll plan to submit the changes, and you can feel free to close them if they are not helpful.

@ap--
Copy link
Collaborator Author

ap-- commented Apr 30, 2023

Having these separated in a branch would be great ❤️

I opened a discussion in the fsspec/cookiecutter-fsspec repo to see if we can help with creating the template, so that more people will benefit from the work.

My guess is that there's gonna be common ground like i.e. ci workflows, using pre-commit etc...

@ap--
Copy link
Collaborator Author

ap-- commented May 3, 2023

So it looks like we should use https://github.com/iterative/py-template as a base and move from there. The added benefit would be, that if the fsspec cookiecutter would eventually use a similar template, we could use https://github.com/cruft/cruft to keep all that development stack updated and in line with other fsspec projects.

@ap--
Copy link
Collaborator Author

ap-- commented Aug 2, 2023

After #105 was merged, there was one release so far. It seems that the new stack is working.
In case there's specific additions to the toolstack, let's open a new issue 😃

@ap-- ap-- closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants