Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronous rmdir() fails silently #38

Open
isoflavone-r opened this issue Oct 14, 2023 · 1 comment
Open

synchronous rmdir() fails silently #38

isoflavone-r opened this issue Oct 14, 2023 · 1 comment

Comments

@isoflavone-r
Copy link

Hello.

Trying to remove directories using SSHFileSystem via rmdir fails silently.

Appears to be missing the synchronous wrapper for _rmdir. i.e. the equivalent of: mkdir = sync_wrapper(_mkdir) and thus ends up all the way in AbstractFileSystem.rmdir which is implemented as pass # not necessary to implement, may not have directories.

A local test of adding the sync_wrapper works ok so far.

@isoflavone-r isoflavone-r changed the title synchronous 'rmdir' fails silently synchronous rmdir() fails silently Oct 14, 2023
@efiop
Copy link
Member

efiop commented Oct 14, 2023

Hey @isoflavone-r , thanks for the report! Makes sense. Would you be interested in contributing a fix? If so, please feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants