-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline_threshold not encoding time value? #468
Comments
It seems inline is only called for normal, non-record arrays. Another thing to fix! Obviously, not too much use of netCDF3 has been seen. |
Well, it's not a high priority for me -- if truth be told, I was really just trying to figure out how to inject a known time value into that reference. |
You can replace the value with a binary, if you want. But also, there already is a function that does exactly this process for any reference set, so it just needs to be invoked. |
Can you point to the function that can inject a known time value or how to replace the value with a binary? |
This may be fixed in #466 , if you would care to try. @kmsampson , the spec says:
so set the key's value in the JSON accordingly. If still in memory, you can also directly assign the binary you want it to have. You could also use the filesystem interface, if you already made a filesystem, fs.pipe("time/0", b"\x00\x00..."); this modification can be outputted again with fs.save_json, or a .flush on the parquet/lazy storage, if you are using that. Too many options? |
Yes, this is fixed in #466: I still can't figure out how to assign a specific value though: |
I would do
and kerchunk.utils._encode_for_JSON or consolidate can do the encoding for you. You can also make a filesystem and interact with it
|
Oh sorry, the function works on the inner reference dict, d["refs"] |
In the example below I was expecting that
time
would get encoded becauseinline_threshold=400
andtime
is only 8 bytes long.Below we see that
depth
is encoded (it's 332 bytes long), buttime
is not.Is this expected behavior?
The text was updated successfully, but these errors were encountered: