Can't unwatch a poll under certain conditions

[MarkusNeblung]

I recognized it with following workflow: create a poll with "show complete results" -> watch the poll -> change poll settings to " never show results". Now I get the error message "You are not allowed to watch this poll.", if I try to unwatch the poll.

I see 2 possible solutions:

Bitpoll/bitpoll/poll/models.py

Lines 122 to 129 in 3e429d0

	def can_watch(self, user: AbstractUser) -> bool:
	if self.can_vote(user) and self.show_results not in ('never', 'summary after vote', 'complete after vote'):
	# If the user can vote and the results are not restricted
	return True
	if self.has_voted(user) and self.show_results not in ('never', ):
	# If the user has voted and can view the results
	return True
	return False

Change the return False to return self.is_ower(user). This will fix the problem only for the owners. But it's possible that other users have the same problem.

Bitpoll/bitpoll/poll/views.py

Lines 323 to 341 in 3e429d0

	@require_POST
	@login_required
	def watch(request, poll_url):
	current_poll = get_object_or_404(Poll, url=poll_url)
	if not current_poll.can_watch(request.user):
	messages.error(
	request, _("You are not allowed to watch this poll.")
	)
	return redirect('poll', poll_url)
	if current_poll.user_watches(request.user):
	poll_watch = PollWatch.objects.get(poll=current_poll, user=request.user)
	poll_watch.delete()
	else:
	poll_watch = PollWatch(poll=current_poll, user=request.user)
	poll_watch.save()
	return redirect('poll', poll_url)

Rearrange this method so that it only throws the error if the user try to watch the poll. This allows to always unwatch to poll.

Beside that it would be helpful if owners always can watch a poll (they can always see the results, so why not allow them always to watch)