Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue when using this when a keyboard was being used in a VC that was presented modally by a tab controller, when the tab bar isn't visible.
The following comment presented a solution that worked:
#19 (comment)
But it only checked if the root view controller was a tab bar. My solution will look at the current visible view controller, and check if it has a tab bar controller where it is not hidden, and account for the tab bar height.
This works in our app with a pretty complicated navigation setup with Navigation Controllers and Tab Controllers, pushing and presenting, but it would be nice to get some other testing on this in other cases. Worst case, it will not change anything if the current view controller doesn't have a
tabBarController
.