From d52a83e779c0d58bb5c0e279a545f9fc724dfa50 Mon Sep 17 00:00:00 2001
From: freezy <freezy@kodi.tv>
Date: Wed, 27 Nov 2024 00:32:00 +0100
Subject: [PATCH] droptarget: Fix animation translation when rotated.

---
 .../VisualPinball.Unity/Game/PhysicsMovements.cs    | 13 +++++++------
 .../VPT/HitTarget/DropTargetComponent.cs            |  1 +
 .../VPT/HitTarget/DropTargetStaticState.cs          |  3 +++
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/VisualPinball.Unity/VisualPinball.Unity/Game/PhysicsMovements.cs b/VisualPinball.Unity/VisualPinball.Unity/Game/PhysicsMovements.cs
index ac69ab194..02e369cd6 100644
--- a/VisualPinball.Unity/VisualPinball.Unity/Game/PhysicsMovements.cs
+++ b/VisualPinball.Unity/VisualPinball.Unity/Game/PhysicsMovements.cs
@@ -65,12 +65,13 @@ internal void ApplyDropTargetMovement(ref NativeParallelHashMap<int, DropTargetS
 			while (enumerator.MoveNext()) {
 				ref var dropTargetState = ref enumerator.Current.Value;
 				var dropTargetTransform = transforms[dropTargetState.AnimatedItemId];
-				var localPos = dropTargetTransform.localPosition;
-				dropTargetTransform.localPosition = new Vector3(
-					localPos.x,
-					Physics.ScaleToWorld(dropTargetState.Animation.ZOffset),
-					localPos.z
-				);
+				var localYDirection = dropTargetTransform.up;
+
+				// Compute the new position by moving along the local Y-axis
+				var newPosition = (Vector3)dropTargetState.Static.InitialPosition + localYDirection * Physics.ScaleToWorld(dropTargetState.Animation.ZOffset);
+
+				// Apply the new position
+				dropTargetTransform.position = newPosition;
 			}
 		}
 
diff --git a/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetComponent.cs b/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetComponent.cs
index 39d88c32e..a381dd3fb 100644
--- a/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetComponent.cs
+++ b/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetComponent.cs
@@ -158,6 +158,7 @@ internal DropTargetState CreateState()
 					Speed = animationComponent.Speed,
 					RaiseDelay = animationComponent.RaiseDelay,
 					UseHitEvent = colliderComponent.UseHitEvent,
+					InitialPosition = transform.position
 				} : default;
 
 			var animationData = colliderComponent && animationComponent
diff --git a/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetStaticState.cs b/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetStaticState.cs
index dceafc631..5a27e8a19 100644
--- a/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetStaticState.cs
+++ b/VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/DropTargetStaticState.cs
@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+using Unity.Mathematics;
+
 namespace VisualPinball.Unity
 {
 	internal struct DropTargetStaticState
@@ -21,5 +23,6 @@ internal struct DropTargetStaticState
 		public float Speed;
 		public float RaiseDelay;
 		public bool UseHitEvent;
+		public float3 InitialPosition;
 	}
 }