use null value

fortunejs · Sep 22, 2015 · 4883cb9 · 4883cb9
1 parent 33f146d
commit 4883cb9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/lib/dispatch/create.js b/lib/dispatch/create.js
@@ -121,7 +121,7 @@ export default function (context) {
     return Promise.all(Object.keys(updates)
       .map(type => updates[type].length ?
         transaction.update(type, updates[type], meta) :
-        Promise.resolve()))
+        null))
   })
 
   .then(() => transaction.endTransaction())

diff --git a/lib/dispatch/delete.js b/lib/dispatch/delete.js
@@ -88,7 +88,7 @@ export default function (context) {
     return Promise.all(Object.keys(updates)
       .map(type => updates[type].length ?
         transaction.update(type, updates[type], meta) :
-        Promise.resolve([])))
+        null))
   })
 
   .then(() => transaction.endTransaction())
@@ -105,10 +105,13 @@ export default function (context) {
       [deleteMethod]: { [type]: ids }
     }
 
-    for (let type of Object.keys(updates)) {
-      if (!updates[type].length) continue
-      if (!(updateMethod in eventData)) eventData[updateMethod] = {}
-      eventData[updateMethod][type] = updates[type].map(mapId)
+    if (Object.keys(updates).length) {
+      eventData[updateMethod] = {}
+
+      for (let type in updates) {
+        if (!updates[type].length) continue
+        eventData[updateMethod][type] = updates[type].map(mapId)
+      }
     }
 
     // Summarize changes during the lifecycle of the request.

diff --git a/lib/dispatch/update.js b/lib/dispatch/update.js
@@ -249,7 +249,7 @@ export default function (context) {
     return Promise.all(Object.keys(relatedUpdates)
       .map(type => relatedUpdates[type].length ?
         transaction.update(type, relatedUpdates[type], meta) :
-        Promise.resolve()))
+        null))
   })
 
   .then(() => transaction.endTransaction())