Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: one-off handling of 1 html entity #1128

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Oct 3, 2023

What does this PR do?

  • manual string.replaceAll for the htmlEntity in this issue, with convenient expansion in the future.
  • see comment about the other options that I found out won't work

What issues does this PR fix or reference?

forcedotcom/cli#2448
@W-14079220@

QA: see comment on issue about what happens when you run retrieve on these (it's never worked, and still doesnt).

The value retrieved from the org turns into a space even when retrieving in mdapi format, so there's nothing we an do about that but raise a bug for the Labels team

@mshanemc mshanemc requested a review from a team as a code owner October 3, 2023 16:45
@shetzel shetzel merged commit 544bccb into main Oct 3, 2023
63 checks passed
@shetzel shetzel deleted the sm/html-entities-take-2 branch October 3, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants