Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadPool not closed #16

Open
thegnarwhals opened this issue Mar 3, 2021 · 0 comments
Open

ThreadPool not closed #16

thegnarwhals opened this issue Mar 3, 2021 · 0 comments

Comments

@thegnarwhals
Copy link

Love this project! A small issue: in mesh.py the ThreadPool is not closed, resulting in the following warning when running under pytest

ResourceWarning: unclosed running multiprocessing pool <multiprocessing.pool.ThreadPool state=RUN pool_size=1>

This can be avoided by using the pool under the context management protocol

with ThreadPool(workers) as pool:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thegnarwhals