Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin error when extracting PSFs too close together #25

Open
clairemitchell308 opened this issue Nov 23, 2022 · 1 comment
Open

Plugin error when extracting PSFs too close together #25

clairemitchell308 opened this issue Nov 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@clairemitchell308
Copy link

Hello

I wanted to report some behaviour of your plugin. It's not necessarily an issue but is maybe something to be aware of.

If points are closer together than the PSF box size then the plugin will only measure one of the points. "Extract PSFs" runs with no error, the problem comes when saving, it looks like you have built in some check to compare the number of points against the number of measurements. In the case outlined above there are fewer measurements than there are points so then upon trying to save the error ValueError: Length of values (xx) does not match length of index (yy) appears where xx is less than yy and the save cannot complete.

Obviously most people aren't going to try to fit points so close together but it's not always obvious when selecting points exactly how big the PSF box will be without a scale bar. So maybe a warning box or something should appear to warn users if they try this?

I realised because my automatic bead finding script was excluding points too close together based on euclidean distance, so at points where my beads were diagonally close together they were not being excluded by my script. I have now fixed this and included a buffer where the distance threshold is larger than the PSF box size and now it seems to work okay.

Thanks a lot
Claire

@tibuch tibuch added the bug Something isn't working label Nov 28, 2022
@tibuch
Copy link
Contributor

tibuch commented Nov 28, 2022

Hi @clairemitchell308,

Thank you for reporting this. This might be a bug and I will have a look.

Best wishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants