Fix MP4 videos saving result in 3GP on Android API <=28

[yishangfei]

Fixed the issue that the video format changes to 3gp when saving mp4 videos to the album on Android 9

[AlexV525]

Could you provide a test case in which saving 3gp will fail? Your changes don't tell the idea and why it will fix the issue well.

[yishangfei]

pubspec.yaml

photo_manager: ^3.3.0
photo_manager_image_provider: ^2.1.1

use my code

device：

Redmi Note5 android 9
MI 8 Lite android 9
MEIZU Note9 android 9

[AlexV525]

It is still unclear why the PR fixes the issue. Could you provide a minimal reproducible example?

[yishangfei]

example code

var appCacheDir = await getApplicationCacheDirectory();
String filePath = '${appCacheDir.path}/aaa.mp4';
File result = File(filePath);
var entity = await PhotoManager.editor.saveVideo(
      result,
     title: path.basename(result.path),
     );  
print('assetEntity===${entity!.title}===${await entity.file}');

On Android 9, the source file is mp4 and converted to 3gp format through saveVideo

[AlexV525]

Is this happening on all videos or just one specific video? Could you file an issue to summarize all the details? And provide a minimal runnable example so we can run to reproduce.

[yishangfei]

All videos on android9

demo: https://github.com/yishangfei/test1

test1.mp4

[AlexV525]

Could you also keep the condition? The fix should work without removing it, correct?

[AlexV525]

What standard do we following here? Should we use MOVIE as much as possible?

[AlexV525]

We seem to already have a helper method checkDir

[yishangfei]

I added it in line 455 according to your latest code.

[AlexV525]

Why we cannot use the filename?

[AlexV525]

Still working on this?

[yishangfei]

now there is no problem. I only modified the version below Android 10. It’s just that the timestamp needs to be used when saving. If the original name is used a second time, the entity returned by PhotoManager.editor.saveVideo will be null.

[AlexV525]

If the original name is used a second time, the entity returned by PhotoManager.editor.saveVideo will be null.

We need to figure out why.

Also please do another rebase on the latest changes and remove unnecessary changes.

[yishangfei]

The automatic renaming function (for example, video (1).mp4) is implemented in Android 11 and above. In earlier versions, if you repeat cr.insert in the insertUri method, an exception will be thrown. "Cannot insert the new asset."

 val uri = cr.insert(contentUri, values) ?: throw RuntimeException("Cannot insert the new asset.")

Just like the pictures I provided before，versions below Android Q use timestamp naming to insert, or write a renaming logic that is the same as that of higher versions.

[AlexV525]

The automatic renaming function (for example, video (1).mp4) is implemented in Android 11 and above.

TIL. Are there any docs referencing this?

EDIT: Could you also write it down as comment in the code?

[yishangfei]

I have not been able to find any official documentation.
I found the solution on stackoverflow.
ContentResolver.insert always returning null

add the following comment to the code. Is it OK?

When using the ContentResolver.insert() method to insert a file with the same name, an exception will indeed be thrown if the file with the same name already exists. This is because in Android 10 and below, MediaStore does not have the automatic renaming function.

[AlexV525]

add the following comment to the code. Is it OK?

How about:

Using a duplicate filename that already exists on the device will cause the insertion to fail on Android API 30-.

[yishangfei]

add the following comment to the code. Is it OK?

How about:

Using a duplicate filename that already exists on the device will cause the insertion to fail on Android API 30-.

i submitted

[AlexV525]

I've also added some format changes and fixed the nullable saving result.

[AlexV525]

Thanks for your contribution.