Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #536 update esbuild version to 0.21.0 #537

Conversation

naotama2002
Copy link

  • update esbuild

Attempts a solution for #536

@johnsonps08
Copy link

It seems as though @aws-sdk/client-cloudformation is no longer compatible with Node <16. Do the checks need to be updated to remove 14 and this be declared a breaking change? Or is there some other path for this to proceed?

@naotama2002
Copy link
Author

@johnsonps08

Thanks for confirming.

First, the fact that the test fails with Node 14 has nothing to do with the esbuild version update.

The cause is the end of support for Node.js 14.x in aws-sdk-js-3 issue #6034.
Therefore, since the release of aws-sdk-js-3 v3.567.0 which includes #6034, tests for Node.js 14 will fail.

Do the checks need to be updated to remove 14 and this be declared a breaking change?

Since Node.js 14 is not listed in the supported runtimes, I think supporting Node.js 16 and 18 is sufficient.

Should we create an issue for end support for Node.js 14.x?

@naotama2002
Copy link
Author

@johnsonps08
Thanks. issue and PR created.

Should we create an issue for end support for Node.js 14.x?

issue: #543
PR: #544

@floydspace floydspace closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants