Issue 14 Fix & Add Timestamps #15

sirkingchase · 2024-03-31T15:34:21Z

This pull request is to fix the issue that is encountered when installing the package as described here: #14 (comment)

This PR also includes the addition of Timestamps to the emeter json value and it adds a new json topic to the switches that contain the status value & timestamp. The timestamps are needed for MQTT v3 persistence to work with QOS > 0

Dependency threw an error when installing, config is my own

Signed-off-by: Chase <sirkingchase@gmail.com>

flavio-fernandes

Thank you so much for doing this! Please take a pass on the changes I asked and see if they make sense.

flavio-fernandes · 2024-04-06T14:24:09Z

data/config.yaml

@@ -39,6 +39,16 @@ locations:
    # example where we indicate a specific poll interval.
    # Also, adding a task to publish emeter info at provided interval

+


hmm... these changes are a bit too specific to you. How about creating a data/config.yaml.sirkingchase and leaving the file as it was originally?

Yes this is my config, I meant to exclude it. I couldnt figure out how to edit my PR after it was submitted.

flavio-fernandes · 2024-04-06T14:25:45Z

data/config.yaml

@@ -114,7 +114,7 @@ locations:
        host: 192.168.66.144


let's keep these on a separate file.

flavio-fernandes · 2024-04-06T14:35:11Z

data/config.yaml

@@ -21,7 +21,7 @@ globals:
    topic_format: /{}/switch
    # kasa will monitor the current state of the device every
    # poll interval, in seconds. You can override on a per device
-    poll_interval: 60
+    poll_interval: 55


I'm curious... why 55?

The logic here is my consumers poll at 60 second intervals so I wanted their to be an overlap between the time kasa pushes the metric and it is consumed. However, I have MQTT queuing working not so it doesnt matter.

flavio-fernandes · 2024-04-06T14:36:32Z

Dockerfile

+WORKDIR /src
+RUN python3 setup.py install
+
+ENTRYPOINT ["python3", "/src/mqtt2kasa/main.py", "/src/data/config.yaml"]


nit, please add end of line

flavio-fernandes · 2024-04-06T14:38:02Z

requirements.txt

@@ -1,4 +1,4 @@
-aiomqtt < 2.0


Hmm... is this PR also adressing #13 ? I suspect not, which makes me think we should not change this line.

So I had some difficulty getting everything to install from scratch but I dont remember the exact error or reason I had to do this, I think it could be because of the version thats in pip

flavio-fernandes · 2024-04-06T14:39:23Z

data/config.yaml

@@ -3,25 +3,25 @@
 knobs:
    # Note: normally you don't set these... here just to show how to
    # devel and debug
-    # log_to_console: false


please create data/config.yaml.sirkingchase and leave this one as is. It is here mostly as an example and should be complete but simple.

flavio-fernandes · 2024-04-06T14:42:22Z

build/lib/mqtt2kasa/bin/create-env.sh

@@ -0,0 +1,21 @@
+#!/bin/bash


Hmm... I am hoping we could move the files here, instead of duplicating them. If that is intentional, then maybe we could consider using symbolic links. Let me thinks a bit more about this.

flavio-fernandes · 2024-04-06T14:43:30Z

AUTHORS

@@ -1 +1,4 @@
+Flavio Fernandes <flavio-fernandes@users.noreply.github.com>


let's remove lines 1 and 4

flavio-fernandes · 2024-04-06T14:45:15Z

build/lib/mqtt2kasa/config.py

@@ -0,0 +1,174 @@
+#!/usr/bin/env python


so much duplication... is that intentional?

flavio-fernandes · 2024-05-04T14:46:26Z

Hi @sirkingchase! Sorry for the delay in addressing this PR. Do you have any updates regarding the changes I suggested? If not, no worries. I welcome your contributions and will try to review them soon, including adding the timestamp you need. However, I'm not sure exactly when I will be able to do so.

Regarding the Dockerfile, the changes seem a bit disorganized. Could you please take another look and possibly clean up the modifications? This would greatly enhance the readability and maintainability of the Docker configuration. Thanks for your efforts!

sirkingchase · 2024-05-05T19:22:52Z

Hi @sirkingchase! Sorry for the delay in addressing this PR. Do you have any updates regarding the changes I suggested? If not, no worries. I welcome your contributions and will try to review them soon, including adding the timestamp you need. However, I'm not sure exactly when I will be able to do so.

Regarding the Dockerfile, the changes seem a bit disorganized. Could you please take another look and possibly clean up the modifications? This would greatly enhance the readability and maintainability of the Docker configuration. Thanks for your efforts!

Hey the timestamp enhancement was included in the PR, I am not sure why its showing that code as a duplicate but there should be the timestamp code in there. FYI I have been using it for the last 3 months and it does exactly what I want - it queues the messages in Mosquitto MQTT and when by consumer comes online it processes the stored backlog.

flavio-fernandes · 2024-05-11T14:00:53Z

Nice. I'm happy to hear it is working for you! What I will do then is to squash all your changes and give it a polish.
Then I will ping you to have a look and confirm it looks good to you. My only ask is for a ton of patience from you,
as I still am not sure when I will get to play with this. #etoomanyballsintheair :)

sirkingchase · 2024-05-11T16:18:24Z

Thanks, I'd like to help with getting the individual emeter values from kasa strips as well (currently this project only has total for entire strip & not individual plugs)

I found this project that has code that does it. I'll work on replicating it here eventually so you may see another pull request from me (I'll try to make it better next time)

The function that loops through the strip is one 162 here: https://github.com/mjonuschat/kasa-plug-exporter/blob/main/kasa_plug_exporter/app.py

Author: Chase <sirkingchase@gmail.com> Date: Fri Mar 29 14:32:25 2024 -0500 added json status to switches with timestamp for MQTT persistantance Fixes: #15 Signed-off-by: Flavio Fernandes <flavio@flaviof.com> Co-authored-by: Chase <sirkingchase@gmail.com>

Author: Chase <sirkingchase@gmail.com> Date: Fri Mar 29 14:32:25 2024 -0500 Added JSON status to switches with timestamp for MQTT persistence. This is a squash of #15 with a few tweaks. Hopefully, it will provide an equivalent solution to what is addressed in that pull request. Fixes: #14 Signed-off-by: Flavio Fernandes <flavio@flaviof.com> Co-authored-by: Chase <sirkingchase@gmail.com>

flavio-fernandes · 2024-05-27T22:13:36Z

Thanks, I'd like to help with getting the individual emeter values from kasa strips as well (currently this project only has total for entire strip & not individual plugs)

I found this project that has code that does it. I'll work on replicating it here eventually so you may see another pull request from me (I'll try to make it better next time)

The function that loops through the strip is one 162 here: https://github.com/mjonuschat/kasa-plug-exporter/blob/main/kasa_plug_exporter/app.py

Let's address that as part of #17

flavio-fernandes · 2024-05-27T22:14:27Z

Closing this PR: it is being folded into #22

sirkingchase added 14 commits February 24, 2024 16:14

Changed config & dependencies

abc2cc8

Dependency threw an error when installing, config is my own

added additional devices

66ed18d

removed duplicate

a0ac072

Updated Config.yaml

fe1897d

Added timestamp as key

c7b4cb4

added timestamp topic as individual call

69213f7

Update config.yaml

efb111b

Signed-off-by: Chase <sirkingchase@gmail.com>

added json topic

de9be49

added json stringify to payload

c2ac14f

store list into dictionary for json dump

c8c2aaa

added timestamp to emeter_json topic

c23ea95

fixed area names

dc02b1f

updated config with reconfigured switches

0322e7f

added json status to switches with timestamp for MQTT persistantance

fa46c99

flavio-fernandes requested changes Apr 6, 2024

View reviewed changes

flavio-fernandes force-pushed the main branch 11 times, most recently from fdf520c to c7362b4 Compare May 26, 2024 02:56

flavio-fernandes force-pushed the main branch 24 times, most recently from 14bb5c2 to e7008c1 Compare May 27, 2024 21:44

flavio-fernandes mentioned this pull request May 27, 2024

Feature/timestamps #22

Merged

flavio-fernandes closed this May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 14 Fix & Add Timestamps #15

Issue 14 Fix & Add Timestamps #15

sirkingchase commented Mar 31, 2024

flavio-fernandes left a comment

flavio-fernandes Apr 6, 2024

sirkingchase May 5, 2024

flavio-fernandes Apr 6, 2024

flavio-fernandes Apr 6, 2024

sirkingchase May 5, 2024

flavio-fernandes Apr 6, 2024

flavio-fernandes Apr 6, 2024

sirkingchase May 5, 2024

flavio-fernandes Apr 6, 2024

flavio-fernandes Apr 6, 2024

flavio-fernandes Apr 6, 2024

flavio-fernandes Apr 6, 2024 •

edited

Loading

flavio-fernandes commented May 4, 2024

sirkingchase commented May 5, 2024

flavio-fernandes commented May 11, 2024

sirkingchase commented May 11, 2024

flavio-fernandes commented May 27, 2024

flavio-fernandes commented May 27, 2024

		@@ -39,6 +39,16 @@ locations:
		# example where we indicate a specific poll interval.
		# Also, adding a task to publish emeter info at provided interval

		@@ -1 +1,4 @@
		Flavio Fernandes <flavio-fernandes@users.noreply.github.com>

Issue 14 Fix & Add Timestamps #15

Issue 14 Fix & Add Timestamps #15

Conversation

sirkingchase commented Mar 31, 2024

flavio-fernandes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flavio-fernandes Apr 6, 2024 • edited Loading

Choose a reason for hiding this comment

flavio-fernandes commented May 4, 2024

sirkingchase commented May 5, 2024

flavio-fernandes commented May 11, 2024

sirkingchase commented May 11, 2024

flavio-fernandes commented May 27, 2024

flavio-fernandes commented May 27, 2024

flavio-fernandes Apr 6, 2024 •

edited

Loading