This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Aave ETH liquidations fixed #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_aave.py
Outdated
| @@ -62,6 +63,11 @@ def test_single_liquidation(trace_classifier: TraceClassifier): | |||
| classified_traces = trace_classifier.classify(block.traces) | |||
| result = get_liquidations(classified_traces) | |||
|
|
|||
| print("Liquidation result:") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a separate transfer classifier spec for the transferToReserve() function on the LendingPoolCore contract. This makes sure that the debt transfer is detected and classified even when the reserve is ETH
Related issue
#313 ETH liquidations on Aave not detected
Testing
Unit test for block 10384319 to check if liquidations for ETH are detected.
Checklist before merging
./mev test