Use namespace import instead of default import for React #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CruseCtrl
force-pushed
the
use-namespace-imports-for-react
branch
from
fa9aedb
to
630262c
Compare
CruseCtrl
force-pushed
the
use-namespace-imports-for-react
branch
from
630262c
to
834bbbd
Compare
|
Hey, why not enable |
|
That's what I've been forced to do for now, but it would be nice if it wasn't necessary for all users of this library to have to turn on that compiler flag, and it's a very easy fix to just import it correctly |
| @@ -1,4 +1,5 @@ | |||
| import React, { useEffect, useLayoutEffect, useRef } from 'react'; | |||
| import * as React from 'react'; | |||
| import { useEffect, useLayoutEffect, useRef } from 'react'; | |||
There was a problem hiding this comment.
This should be
import * as React from 'react';
const { useEffect, useLayout, useRef } = React;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have
allowSyntheticDefaultImportsset in my project, so the typescript compiler is giving me warnings about these imports. This PR will fix the warnings