Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing “Payroll Adjustment”, “Payroll Check”, “Sales Tax Payment”, and “Tax Payment” transaction types #55

Open
2 of 4 tasks
mel-restori opened this issue Nov 15, 2022 · 4 comments
Labels
type:wontfix This will not be worked on

Comments

@mel-restori
Copy link
Contributor

mel-restori commented Nov 15, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Investigating discrepancies between Quickbooks UI and the quickbooks__balance_sheet, I find that there were several transactions of type “Payroll Adjustment”, “Payroll Check”, “Sales Tax Payment”, and “Tax Payment” in Quickbooks that aren't anywhere to be found in the balance_sheet or ledger. I also looked in the raw data files and couldn't find them there either. Even though there were only a few of these transactions and only on a few days in 2021, they impact the account the payments were made from and a myriad of other balance sheet liabilities for taxes and benefits.

Relevant error log or model output

No response

Expected behavior

We expect all transactions of all types that are in the Quickbooks UI to be reflected in the relevant data models

dbt Project configurations

# quickbooks:
using_address:        true
using_bill:           true
using_credit_memo:    true
using_department:     true
using_deposit:        true
using_estimate:       true
using_invoice:        true
using_invoice_bundle: true
using_journal_entry:  true
using_payment:        true
using_refund_receipt: true
using_transfer:       true
using_vendor_credit:  true
using_sales_receipt:  true
using_purchase_order: true
using_credit_card_payment_txn: true

Package versions

packages:

note: using this branch to make sure we're properly counting credit card payment transactions

What database are you using dbt with?

bigquery

dbt Version

unknown

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@mel-restori mel-restori added the bug Something isn't working label Nov 15, 2022
@mel-restori mel-restori changed the title [Bug] Missing “Payroll Adjustment” and “Payroll Check” transaction types [Bug] Missing “Payroll Adjustment”, “Payroll Check”, “Sales Tax Payment”, and “Tax Payment” transaction types Nov 15, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @mel-restori thanks for opening this issue. Unfortunately I do not believe this is something we can address within the package at the moment if the connector does not have these source tables.

It looks like there is a similar Feature Request open on the Fivetran Support portal that goes into the Payroll piece of your original issue. I would recommend posting in this feature request to talk directly to our Product Manager and raise the importance of these transaction types. They can then work with you to see if this is possible to bring into the connector.

@mel-restori
Copy link
Contributor Author

thanks @fivetran-joemarkiewicz ! I'll ask someone from the team (and thus a Fivetran login) to upvote and comment on that thread.

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Nov 22, 2022

Sounds great! I will mark this as wontfix for the time being as it is something we cannot address within the package until the source tables are included.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the wontfix This will not be worked on label Nov 22, 2022
@mel-restori
Copy link
Contributor Author

that makes sense, thank you!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:bug Something is broken or incorrect and removed bug Something isn't working labels Feb 22, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title [Bug] Missing “Payroll Adjustment”, “Payroll Check”, “Sales Tax Payment”, and “Tax Payment” transaction types Missing “Payroll Adjustment”, “Payroll Check”, “Sales Tax Payment”, and “Tax Payment” transaction types Feb 22, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement and removed type:bug Something is broken or incorrect labels Feb 22, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:wontfix This will not be worked on and removed wontfix This will not be worked on type:enhancement New functionality or enhancement labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants