Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add progress bar to CLI fetch #11

Closed
antons- opened this issue Dec 11, 2018 · 5 comments
Closed

✨ Add progress bar to CLI fetch #11

antons- opened this issue Dec 11, 2018 · 5 comments

Comments

@antons-
Copy link
Contributor

antons- commented Dec 11, 2018

This has been needed for a long time, especially with larger Hail organisations with lots of objects.

The current CLI output looks like this. Not nice.

Running Task HailFetchTask

Fetching HailArticleFetching HailImageFetching HailPublicationFetching HailTagFe

We should change it to something like this. Add colors too, why not, and maybe a verbose param so we can see exactly what is being processed.

Running Task HailFetchTask...

Fetching HailArticle...
[====================] 100% (400 of 400)

Fetching HailImage...
[==========__________]  50% (60 of 120)

Whatever is built will need to play nice with cron jobs, more so if the output is emailed once the job is done.

@maxime-rainville
Copy link
Contributor

I would suggest you have a look at symfony/console. It makes a lot of those processes like adding progress bars and adding pretty colours to your output a breeze.

@antons-
Copy link
Contributor Author

antons- commented Dec 11, 2018

Ta, thanks for that @maxime-rainville - I was trying to find this yesterday.

@maxime-rainville
Copy link
Contributor

We're thinking about refactoring our own build task around it at some stage. silverstripe/silverstripe-framework#5542

@antons-
Copy link
Contributor Author

antons- commented Dec 11, 2018

Awesome, I would be very keen for this to happen!

@marc-firebrand
Copy link
Contributor

Added:
SS3 (6d5b118)
SS4 (e77d25c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants