-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marc Gratacos Updated Qualifying functions for Known Amount ZC #2560
Closed
regnosys-prod-user
wants to merge
16
commits into
finos:5.x.x
from
rosetta-models:mgratacos_auth0_5bbb11b408c77d25edcf5ac2-ZCKnownAmount
Closed
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
087f513
Update RELEASE.md
JayasriR 1775846
Update RELEASE.md
hugohills-regnosys ebdf45c
Update RELEASE.md
hugohills-regnosys cbb048e
Update RELEASE.md
eacunaISDA 8e9c837
Add PR link
lolabeis 78cd9c2
Merge pull request #2549 from rosetta-models/task-6602-6-dev
lolabeis 84f14f0
Updated Qualifying functions for Known Amount ZC
mgratacos 42aedde
Fix CVE scanning (#2561)
SimonCockx b297b46
Prevent GitHub Actions from being triggered twice (#2559)
SimonCockx 7182a16
Merge branch 'master' into mgratacos_auth0_5bbb11b408c77d25edcf5ac2-Z…
hugohills-regnosys ec7144c
Updated Qualifying functions for Known Amount ZC 2
mgratacos f1c31cb
Revert "Prevent GitHub Actions from being triggered twice (#2559)"
hugohills-regnosys f520060
Revert "Fix CVE scanning (#2561)"
hugohills-regnosys 8357921
Fix release notes
hugohills-regnosys 506f6ac
Add release note
hugohills-regnosys d1de3fb
Fix syntax validation error and update docs code snippet
hugohills-regnosys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -910,15 +910,15 @@ func Qualify_SubProduct_FixedFloat: <"Qualifies a product as having the Sub Prod | |
|
||
set is_product: | ||
(economicTerms -> payout -> interestRatePayout -> rateSpecification -> fixedRate count = 1 | ||
and economicTerms -> payout -> interestRatePayout -> rateSpecification -> floatingRate count = 1) | ||
or (economicTerms -> payout -> interestRatePayout -> rateSpecification -> fixedRate count = 1 | ||
and economicTerms -> payout -> interestRatePayout -> rateSpecification -> inflationRate count = 1) | ||
or ((economicTerms -> payout -> interestRatePayout -> rateSpecification -> fixedRate is absent | ||
and economicTerms -> payout -> interestRatePayout -> principalPayment -> finalPayment only-element = True) | ||
and (economicTerms -> payout -> interestRatePayout -> rateSpecification -> floatingRate count = 1 | ||
or economicTerms -> payout -> interestRatePayout -> rateSpecification -> inflationRate count = 1)) | ||
and economicTerms -> payout -> interestRatePayout -> rateSpecification -> floatingRate count = 1) | ||
or (economicTerms -> payout -> interestRatePayout -> rateSpecification -> fixedRate count = 1 | ||
and economicTerms -> payout -> interestRatePayout -> rateSpecification -> inflationRate count = 1) | ||
or ((economicTerms -> payout -> interestRatePayout -> rateSpecification -> floatingRate count = 1 | ||
or economicTerms -> payout -> interestRatePayout -> rateSpecification -> inflationRate count = 1) | ||
and (economicTerms -> payout -> interestRatePayout | ||
filter rateSpecification is absent and priceQuantity exists then count = 1)) | ||
|
||
func Qualify_SubProduct_FixedFixed: <"Qualifies a product as having the Sub Product classification Fixed Float"> | ||
func Qualify_SubProduct_FixedFixed: <"Qualifies a product as having the Sub Product classification Fixed Fixed"> | ||
inputs: | ||
economicTerms EconomicTerms (1..1) | ||
output: | ||
|
@@ -943,8 +943,19 @@ func Qualify_Transaction_ZeroCoupon: <"Qualifies a product as having the Transac | |
output: | ||
is_product boolean (1..1) | ||
set is_product: | ||
economicTerms -> payout -> interestRatePayout -> paymentDates -> paymentFrequency -> periodMultiplier all = 1 | ||
and economicTerms -> payout -> interestRatePayout -> paymentDates -> paymentFrequency -> period all = PeriodExtendedEnum -> T | ||
economicTerms -> payout -> interestRatePayout -> paymentDates -> paymentFrequency | ||
filter item -> periodMultiplier = 1 and item -> period = PeriodExtendedEnum -> T then exists | ||
|
||
func Qualify_Transaction_ZeroCoupon_KnownAmount: <"Qualifies a product as having the Transaction classification Zero Coupon with a Known Amount. This category applies to a Zero Coupon Swap in which the fixed leg pays a known amount at maturity."> | ||
inputs: | ||
economicTerms EconomicTerms (1..1) | ||
output: | ||
is_product boolean (1..1) | ||
set is_product: | ||
Qualify_SubProduct_FixedFloat(economicTerms) = True and | ||
Qualify_Transaction_ZeroCoupon(economicTerms) = True and | ||
(economicTerms -> payout -> interestRatePayout | ||
filter item -> priceQuantity exists and rateSpecification is absent and paymentDates -> paymentFrequency -> periodMultiplier = 1 and paymentDates -> paymentFrequency -> period = PeriodExtendedEnum -> T then exists) | ||
|
||
func Qualify_Transaction_YoY: <"Qualifies a product as having the Transaction classification Year on Year"> | ||
inputs: | ||
|
@@ -1084,7 +1095,7 @@ func Qualify_InterestRate_IRSwap_Basis: <"Qualifies a product as a Basis (Float- | |
and Qualify_SubProduct_Basis(economicTerms) = True | ||
and Qualify_Transaction_OIS(economicTerms) = False | ||
|
||
func Qualify_InterestRate_IRSwap_FixedFloat_ZeroCoupon: <"Qualifies a product as a Fixed-Float Zero Coupon Interest Rate Swap based on the economic terms and the following criteria: 1) An interest rate product with one fixed and one floating leg and more than one payment, 2) without inflation features or cross-currency features, and 3) where the floating leg is not based on an OIS index."> | ||
func Qualify_InterestRate_IRSwap_FixedFloat_ZeroCoupon: <"Qualifies a product as a Fixed-Float Zero Coupon Interest Rate Swap based on the economic terms and the following criteria: 1) An interest rate product with one fixed and one floating leg, 2) where the fixed leg represents one singular payment agreed upon execution and to be made at maturity, 3) where the floating leg is not based on an OIS index and 4) without any inflation features or cross-currency features."> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function should call Qualify_Transaction_ZeroCoupon_KnownAmount |
||
[qualification Product] | ||
inputs: | ||
economicTerms EconomicTerms (1..1) | ||
|
@@ -1191,7 +1202,7 @@ func Qualify_InterestRate_InflationSwap_FixedFloat_YearOn_Year: <"Qualifies a pr | |
* and Qualify_InterestRate_InflationSwap_Basis_ZeroCoupon (economicTerms) = False | ||
* and Qualify_InterestRate_InflationSwap_Basis_YearOn_Year (economicTerms) = False | ||
*/ | ||
func Qualify_InterestRate_InflationSwap_FixedFloat_ZeroCoupon: <"Qualifies a product as a Fixed-Float Inflation Swap with a single accrual period based on the economic terms and the following criteria: 1) An interest rate product with one fixed and one inflation rate leg and more than one payment, and 2) without cross-currency features."> | ||
func Qualify_InterestRate_InflationSwap_FixedFloat_ZeroCoupon: <"Qualifies a product as a Fixed-Float Inflation Swap based on the economic terms and the following criteria: 1) An interest rate product with one fixed and one inflation rate leg, 2) where the fixed leg represents one singular payment agreed upon execution and to be made at maturity, 3) where the inflation leg features an inflation floating rate and 4) without cross-currency features."> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function should call Qualify_Transaction_ZeroCoupon_KnownAmount |
||
[qualification Product] | ||
inputs: | ||
economicTerms EconomicTerms (1..1) | ||
|
@@ -1219,7 +1230,7 @@ func Qualify_InterestRate_InflationSwap_Basis_YearOn_Year: <"Qualifies a product | |
and Qualify_SubProduct_Basis(economicTerms) = True | ||
and Qualify_Transaction_YoY(economicTerms) = True | ||
|
||
func Qualify_InterestRate_InflationSwap_Basis_ZeroCoupon: <"Qualifies a product as a Basis (Float-Float) Inflation Swap with a single accrual period based on the economic terms and the following criteria: 1) An interest rate product with one floating interest rate leg and one inflation rate leg and more than one payment, and 2) without cross-currency features or 'zero coupon' features."> | ||
func Qualify_InterestRate_InflationSwap_Basis_ZeroCoupon: <"Qualifies a product as a Basis (Float-Float) Inflation Swap based on the economic terms and the following criteria: 1) An interest rate product with one floating interest rate leg and one inflation interest rate leg, 2) where the floating leg is not based on an OIS index, 3) where the inflation leg features an inflation floating rate, 4) where an interest rate payout is made at maturity into a singular payment and 5) without cross-currency features."> | ||
[qualification Product] | ||
inputs: | ||
economicTerms EconomicTerms (1..1) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic should rather check that if rateSpecification is present it is a fixed rate. The peer review group indicated that a Zerocoupon_knownamount can also feature accruals but they have to be deterministic i.e. fixed rate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't include the fixed rate. That's the whole point about ZC with a Known Amount. There is no fixed rate in the fixed leg. The Known Amount is the result of the accrued fixed rate calculations so the fixed rate is not included as part of the product representation, only the resulting calculated amount.