Adding new features and refactoring #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Добавление UUID * Добавление middleName * Добавление userGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all thank you very much for this project, it helped a lot on our project :)
But unfortunately, everything was not as smooth as we would like, so the plugin had to be updated. I open the pull request because I hope that these are useful changes.
For reference, we use our own oauth2 server in our project
Refactoring
This mainly affected the creation and updating of entities and groups. I Packed everything in a DTO class for convenience.
I also expanded the number of fields that can be obtained from the SSO server
New features
There is a new field in the settings, the user exit token. Why is it needed? We needed this when it was necessary to make a simultaneous exit in all SSO-related applications. In other words, if a user logs out of app A, then they must also log out of app B, which is lifray.
In order for the SSO server to log out any user to liferay, it calls the /portal/logout method with the ServiceAuth header, which is set in the settings, and the request parameter of the user's UUID in liferay
For more information about the implementation, see LibFilter#processFilter.