Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Point3f to simply array #5

Open
tischi opened this issue Feb 9, 2020 · 0 comments
Open

Refactor Point3f to simply array #5

tischi opened this issue Feb 9, 2020 · 0 comments
Assignees

Comments

@tischi
Copy link
Collaborator

tischi commented Feb 9, 2020

The current code contains unnecessary Point3f java objects, which make it overly complicated.
Would be much simpler to have 3D arrays.
For example, code like below could be replaced by loops or even on-liners:

    minx = min(minx, shift.x)
    miny = min(miny, shift.y)
    minz = min(minz, shift.z)
@tischi tischi self-assigned this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant