Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled error printout with cli client #18

Closed
fubuloubu opened this issue May 30, 2024 · 4 comments · Fixed by #19
Closed

Unhandled error printout with cli client #18

fubuloubu opened this issue May 30, 2024 · 4 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@fubuloubu
Copy link

Describe the bug

I followed the docs for the cli version of the client (which works!), however it seems like an unhandled exception towards the end of that process keeps printing to the console

To Reproduce

Followed steps from here: https://docs.fief.dev/integrate/python/cli/

In [3]: client.authorize()
Out [3]: ...  # access_token stuff
Error in callback <function Halo.__init__.<locals>.clean_up at 0x744c898153a0> (for post_run_cell), with arguments args (<ExecutionResult object at 744c898249d0, ...
TypeError: Halo.__init__.<locals>.clean_up() takes 0 positional arguments but 1 was given

Expected behavior

Doesn't appear to affect operation, but is annoying to see this error no matter what is happening lol

Configuration

  • Python version:3.11.9

  • Fief client version: 0.18.6

  • Fief Cloud or self-hosted: self-hosted (Railway)

  • If self-hosted, Fief version: 0.28.6

Additional context

Very sweet having a CLI client! (need it for our use case)

@fubuloubu fubuloubu added the bug Something isn't working label May 30, 2024
@fubuloubu
Copy link
Author

related: manrajgrover/halo#180

halo seems unmaintained

@fubuloubu
Copy link
Author

This seems much more active: https://pypi.org/project/yaspin/

@frankie567
Copy link
Member

Good catch, thank you! Would be happy to review a PR replacing halo by yaspin :)

@fubuloubu
Copy link
Author

Good catch, thank you! Would be happy to review a PR replacing halo by yaspin :)

Yeah will do, this seems like an easy migration lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants