Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message file structure #79

Open
9 tasks
olemis opened this issue Nov 22, 2019 · 0 comments
Open
9 tasks

Refactor message file structure #79

olemis opened this issue Nov 22, 2019 · 0 comments

Comments

@olemis
Copy link
Collaborator

olemis commented Nov 22, 2019

Is your feature request related to a problem? Please describe.
There are many (unrelated) message definitions in a single file.

Describe the solution you'd like
Group messages by similar purpose .

  • Coin-specific messages in messages-${COIN}.proto file
  • Bootloader messages in message-bootloader.proto file
  • Generic reusable messages in message-common.proto file
  • Messages for cryptographic operations in message-crypto.proto file
  • Debug messages in message-debug.proto file
  • Management messages in message-management.proto file
  • Web authentication messages in message-webauthn.proto file
  • Message integer IDs in message.proto file
  • Script to merge them into a single file

Describe alternatives you've considered
Keeping a single file is unmanageable not an option

Additional context
Based on Trezor definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants