Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams are not loaded/displayed #70

Open
comturaRalph opened this issue Jan 18, 2024 · 11 comments
Open

Teams are not loaded/displayed #70

comturaRalph opened this issue Jan 18, 2024 · 11 comments

Comments

@comturaRalph
Copy link

comturaRalph commented Jan 18, 2024

Platform (Hardware/OS):
Raspberry Pi 4 / Raspberry PI OS (Legacy, 32-Bit)

Node version:
20.8.0
MagicMirror version:
2.26.0
Module version:
2.2.1
Description of the issue:
Hello,
I carried out the installation exactly according to your instructions. However, the Teams are not loaded/displayed.
image

Do I have something wrong here in the config?

{
  module: 'MMM-soccer',
  position: 'bottom_left',
  config: {
    api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
    show: 'GERMANY',
	logos: 'true',
    colored: 'true',
    focus_on: {
      "GERMANY": "SC Freiburg"
    },
    max_teams: '36',
    leagues: {
      "GERMANY": "BL1"
    }
  }
},
@comturaRalph comturaRalph changed the title module is not loaded/displayed Teams are not loaded/displayed Jan 18, 2024
@mpzross
Copy link

mpzross commented Jan 19, 2024

Exact same here

@fewieden
Copy link
Owner

@comturaRalph @mpzross I looked into your provided config and spotted some errors:

{
  module: 'MMM-soccer',
  position: 'bottom_left',
  config: {
    api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
    show: 'GERMANY', // this is the default and can be ommited
    logos: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
    colored: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
    focus_on: {
      "GERMANY": "SC Freiburg"
    },
    max_teams: '36', // numbers in JavaScript have no quotes around them, this would be a string now. Also 36 doesn't make sense, in the Bundesliga are only 18 teams. By default it shows all teams so you can also omit this, you only need to specify it if you want to show less.
    leagues: {  // this is the default and can be ommited
      "GERMANY": "BL1"
    }
  }
},

What it ideally would look like:

{
	module: 'MMM-soccer',
	position: 'bottom_left',
	config: {
		api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
		logos: true,
		colored: true,
		focus_on: {
			GERMANY: 'SC Freiburg'
		}
	}
},

However, this is not the only problem, v2 of the API doesn't return the necessary data anymore and there is no longer support for it. I need to switch to v4 to make it work again. Can you please test the work in progress?

cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci

image

@fewieden fewieden added the bug label Feb 13, 2024
@fewieden fewieden mentioned this issue Feb 13, 2024
@mpzross
Copy link

mpzross commented Feb 20, 2024 via email

@fewieden
Copy link
Owner

fewieden commented Mar 3, 2024

@mpzross your attachment from your mail didn't make it to GitHub. Can you please upload the file directly to GitHub so I can have a look?

@mpzross
Copy link

mpzross commented Mar 6, 2024

Apologies. my fault for not giving it a recognised suffix. Thank you again for your work
MM-log-20.2.24.docx

@fewieden
Copy link
Owner

@mpzross it says your branch is already up to date, which shouldn't be the case since I made changes. Therefore I think you are not on the correct branch. Can you please run git status in the MMM-soccer directory and share the output?

@P-kxox
Copy link

P-kxox commented Mar 21, 2024

Hallo,
ich habe genau das gleiche Problem.... habe git status MMM-soccer eingeben
es steht dran:
git status MMM-soccer
Auf Branch master
Ihr Branch ist auf demselben Stand wie 'origin/master'

@fewieden
Copy link
Owner

@P-kxox the fix is not available on the master branch yet. Please follow the steps to switch to the develop branch which contains the fix

cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci

@mpzross
Copy link

mpzross commented Mar 23, 2024

@mpzross it says your branch is already up to date, which shouldn't be the case since I made changes. Therefore I think you are not on the correct branch. Can you please run git status in the MMM-soccer directory and share the output?

new 1.txt

@mpzross
Copy link

mpzross commented Mar 23, 2024

@P-kxox the fix is not available on the master branch yet. Please follow the steps to switch to the develop branch which contains the fix

cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci

This is a log of what I get when I try these instructions. Previously I updated and upgraded the pi installation through putty:
2024-03-23T15_53_53_541Z-debug-0.log

@P-kxox
Copy link

P-kxox commented Mar 25, 2024

Habe dies nun durchgeführt...
git status MMM-soccer :
Auf Branch develop
Ihr Branch ist auf demselben Stand wie 'origin/develop'

Leider zeigt es mir immernoch nicht die Tabelle an sondern nur den ,,header´´

Danke für euer Unterstützung schonmal:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants