-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teams are not loaded/displayed #70
Comments
Exact same here |
@comturaRalph @mpzross I looked into your provided config and spotted some errors: {
module: 'MMM-soccer',
position: 'bottom_left',
config: {
api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
show: 'GERMANY', // this is the default and can be ommited
logos: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
colored: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
focus_on: {
"GERMANY": "SC Freiburg"
},
max_teams: '36', // numbers in JavaScript have no quotes around them, this would be a string now. Also 36 doesn't make sense, in the Bundesliga are only 18 teams. By default it shows all teams so you can also omit this, you only need to specify it if you want to show less.
leagues: { // this is the default and can be ommited
"GERMANY": "BL1"
}
}
}, What it ideally would look like: {
module: 'MMM-soccer',
position: 'bottom_left',
config: {
api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
logos: true,
colored: true,
focus_on: {
GERMANY: 'SC Freiburg'
}
}
}, However, this is not the only problem, v2 of the API doesn't return the necessary data anymore and there is no longer support for it. I need to switch to v4 to make it work again. Can you please test the work in progress? cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci |
Thank you for all your efforts. I've updated the MagicMirror and run the
commands you suggested but I get a lot of npm warnings. File attached
…On Tue, 13 Feb 2024 at 07:28, fewieden ***@***.***> wrote:
@comturaRalph <https://github.com/comturaRalph> @mpzross
<https://github.com/mpzross> I looked into your provided config and
spotted some errors:
{
module: 'MMM-soccer',
position: 'bottom_left',
config: {
api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
show: 'GERMANY', // this is the default and can be ommited
logos: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
colored: 'true', // booleans in JavaScript have no quotes around them, this would be a string now and strings are always considered as true, except for empty strings, e.g. 'false' would still be true
focus_on: {
"GERMANY": "SC Freiburg"
},
max_teams: '36', // numbers in JavaScript have no quotes around them, this would be a string now. Also 36 doesn't make sense, in the Bundesliga are only 18 teams. By default it shows all teams so you can also omit this, you only need to specify it if you want to show less.
leagues: { // this is the default and can be ommited
"GERMANY": "BL1"
}
}},
What it ideally would look like:
{
module: 'MMM-soccer',
position: 'bottom_left',
config: {
api_key: 'XXXXXXXXXXXXXXXXXXXXXXXXX',
logos: true,
colored: true,
focus_on: {
GERMANY: 'SC Freiburg'
}
}},
However, this is not the only problem, v2 of the API doesn't return the
necessary data anymore and there is no longer support for it. I need to
switch to v4 to make it work again. Can you please test the work in
progress?
cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci
image.png (view on web)
<https://github.com/fewieden/MMM-soccer/assets/9334168/dd53e789-959f-49b6-9ff1-092ab6cca322>
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTVJQ7KWSLFYBVIUJTW2TDYTMIYXAVCNFSM6AAAAABB7Z27R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGU3TSMRQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@mpzross your attachment from your mail didn't make it to GitHub. Can you please upload the file directly to GitHub so I can have a look? |
Apologies. my fault for not giving it a recognised suffix. Thank you again for your work |
@mpzross it says your branch is already up to date, which shouldn't be the case since I made changes. Therefore I think you are not on the correct branch. Can you please run |
Hallo, |
@P-kxox the fix is not available on the master branch yet. Please follow the steps to switch to the develop branch which contains the fix cd ~/MagicMirror/modules/MMM-soccer
git checkout develop
git pull
npm ci |
This is a log of what I get when I try these instructions. Previously I updated and upgraded the pi installation through putty: |
Habe dies nun durchgeführt... Leider zeigt es mir immernoch nicht die Tabelle an sondern nur den ,,header´´ Danke für euer Unterstützung schonmal:) |
Platform (Hardware/OS):
Raspberry Pi 4 / Raspberry PI OS (Legacy, 32-Bit)
Node version:
20.8.0
MagicMirror version:
2.26.0
Module version:
2.2.1
Description of the issue:
Hello,
I carried out the installation exactly according to your instructions. However, the Teams are not loaded/displayed.
Do I have something wrong here in the config?
The text was updated successfully, but these errors were encountered: