Matrix view #9
Open
Matrix view #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add linters
* Added WienerLinien disruption info (lines and elevators) (fewieden#3) * Added functions to display interuptions to lines and elevators * Added .gitignore from MM * Fixed typos in README.md * Changed line disruptions text to full description * removed unused property * Fixed lint errors * Fixed README for config parameter name change * removed project unrelated gitignores * github templates * translations, changelog and cleanup of pr fewieden#3
|
I really like the looks of it! |
fruestueck
reviewed
Oct 12, 2019
fruestueck
reviewed
Oct 12, 2019
| /* eslint-disable func-names */ | ||
| /* eslint-disable prefer-arrow-callback */ | ||
| /* eslint-disable no-var */ | ||
| /* eslint-disable vars-on-top */ |
There was a problem hiding this comment.
This just disables some linting warnings, you can get rid of it, then you will see a few warnings
fruestueck
reviewed
Oct 12, 2019
Comment on lines
-204
to
+300
| for (let i = 0; i < this[type].length; i += 1) { | ||
| for (var i = 0; i < this[type].length; i += 1) { |
There was a problem hiding this comment.
I am using an old ipad as magic mirror device. And the old safari version does not work with let, this is why I use vars. (on newer browsers it also works with let)
Comment on lines
-232
to
+329
| let temp = text; | ||
| var temp = text; | ||
|
|
There was a problem hiding this comment.
Same here (var)?
newline not necessary. Style thing thou.
Comment on lines
-7
to
+11
|    | ||
|     | ||
|
|
||
|
|
||
| Matrix view | ||
|  |
There was a problem hiding this comment.
Added images are to big.
I'd also reduce the amount of images. Maby swap example-matrix with example2. Should be enoth.
| @@ -37,7 +41,8 @@ Public Transport of Vienna/Austria Module for MagicMirror<sup>2</sup> | |||
| | --- | --- | --- | | |||
| | `api_key` | REQUIRED | Get an API key for free access to the data of www.wienerlinien.at [here](https://www.wien.gv.at/formularserver2/user/formular.aspx?pid=3b49a23de1ff43efbc45ae85faee31db&pn=B0718725a79fb40f4bb4b7e0d2d49f1d1). | | |||
| | `stations` | REQUIRED | Insert here the station ids you want to display data from [How to find an ID?](https://till.mabe.at/rbl/). | | |||
| | `max` | `5` | How many departures should be displayed. | | |||
| | `display` | `list` | Show departures as list or as `matrix` (see screenshots). | | |||
There was a problem hiding this comment.
Both options - matrix and list -should be highlighted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new matrix view (i.e. one line per destination with several departure times)
Screenshot: