-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation time milestones #568
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 99.07% 98.90% -0.18%
==========================================
Files 56 56
Lines 2053 2096 +43
==========================================
+ Hits 2034 2073 +39
- Misses 19 23 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, I know some people who've asked for this feature.
Proposed changes
Often it is required to have the simulation hit some time milestones.
For instance, I want the simulation to simulate t=100s explicitely, not 80s, not 150s, 100s.
So far, we could use TXT exports that would modify the stepsize accordingly.
We can now do it directly in
festim.Stepsize
by specifyingmilestones
.Usage
In the current implementation, the TXT export don't modify the stepsize anymore. Meaning that users must add milestones if they want to be sure to export the TXT at these specific times.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist