Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: simplify Settings.transient and Settings.final_time #847

Open
RemDelaporteMathurin opened this issue Jul 31, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@RemDelaporteMathurin
Copy link
Collaborator

# TODO maybe transient and final_time are redundant
self.transient = transient
self.final_time = final_time

It can be annoying to have to set both the arguments final_time and transient as it is kind of redundant.
If we provide a final time, then obviously the simulation is transient.

We could simplify this by removing the transient argument altogether and replace it by a property attribute of Settings.

@property
def transient(self):
    return self.final_time is not None
@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the UKAEA workshop milestone Jul 31, 2024
@RemDelaporteMathurin RemDelaporteMathurin removed this from the UKAEA workshop milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant