Merge remote-tracking branch 'upstream/fenicsx' into trap-density-spa…

…ce-time
festim-dev · Nov 4, 2024 · 300e9bf · 300e9bf
2 parents 6130c09 + db4ad6f
commit 300e9bf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/docs/source/devguide/index.rst b/docs/source/devguide/index.rst
@@ -1,3 +1,5 @@
+.. _developers_guide:
+
 =================
 Developer's Guide
 =================

diff --git a/docs/source/userguide/beginners_guide.rst b/docs/source/userguide/beginners_guide.rst
@@ -10,7 +10,7 @@ To make the most out of FESTIM, a basic knowledge of `Python <https://www.learnp
 
 Depending on how you install FESTIM, new users should familiarise with either `Docker <https://www.docker.com/>`_ or `Conda <https://anaconda.org/>`_.
 
-FESTIM is under version control with `git <https://git-scm.com/>`_. Even though users don't need git to install FESTIM, it is convenient to have a basic understanding of how it works. You can fin `git turorials <https://git-scm.com/doc>`_ to help you getting started. The `FESTIM source code <https://github.com/RemDelaporteMathurin/FESTIM>`_ is hosted on GitHub. It is recommended to sign up for free to GitHub in order to receive the latest updates, follow the development and submit `bug reports <https://github.com/RemDelaporteMathurin/FESTIM/issues/new/choose>`_.
+FESTIM is under version control with `git <https://git-scm.com/>`_. Even though users don't need git to install FESTIM, it is convenient to have a basic understanding of how it works. You can find `git tutorials <https://git-scm.com/doc>`_ to help you getting started. The `FESTIM source code <https://github.com/festim-dev/FESTIM>`_ is hosted on GitHub. Git knowledge and a GitHub account is required to open issues and :ref:`contribute to the code <developers_guide>`.
 
 ----------------------
 Where can I find help?

diff --git a/src/festim/hydrogen_transport_problem.py b/src/festim/hydrogen_transport_problem.py
@@ -47,7 +47,6 @@ class HydrogenTransportProblem(problem.ProblemBase):
         sources: The hydrogen sources
         initial_conditions: The initial conditions
         boundary_conditions: The boundary conditions
-        solver_parameters (dict): the solver parameters of the model
         exports (list of festim.Export): the exports of the model
         traps (list of F.Trap): the traps of the model
 
@@ -60,7 +59,6 @@ class HydrogenTransportProblem(problem.ProblemBase):
         sources: The hydrogen sources
         initial_conditions: The initial conditions
         boundary_conditions: List of Dirichlet boundary conditions
-        solver_parameters (dict): the solver parameters
         exports (list of festim.Export): the export
         traps (list of F.Trap): the traps of the model
         dx (dolfinx.fem.dx): the volume measure of the model

diff --git a/src/festim/problem.py b/src/festim/problem.py
@@ -154,6 +154,7 @@ def run(self):
                 self.iterate()
             if self.show_progress_bar:
                 self.progress_bar.refresh()  # refresh progress bar to show 100%
+                self.progress_bar.close()
         else:
             # Solve steady-state
             self.solver.solve(self.u)