Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of Keycloak OpenID Connect Node.js Adapter #110

Open
sirkrypt0 opened this issue Feb 5, 2022 · 6 comments
Open

Deprecation of Keycloak OpenID Connect Node.js Adapter #110

sirkrypt0 opened this issue Feb 5, 2022 · 6 comments
Labels
Type: Dependencies Pull requests that update a dependency file Type: Documentation Improvements or additions to documentation

Comments

@sirkrypt0
Copy link

First, thanks for your work on this library!

According to the official Deprecation of Keycloak adapters post (and the corresponding GitHub discussion), the keycloak-nodejs-connect adapter (which this library relies on) is now being deprecated and will receive major/minor releases only until September 2022.

Even though they are still looking around for the best alternative for users, they suggest the openid-client package in the mentioned blog post.

I'm kindly asking whether you plan on migrating this library to an alternative, such as the openid-client package.

@ferrerojosh
Copy link
Owner

I think the proper move would be to implement calling Keycloak's authorization API ourselves instead of relying on their official Node.js adapter. I assume authorization services won't be going away soon. The implementation is all there and all we need to do is move over the implementation into typescript and use an http client (i.e axios or node net)

@ferrerojosh ferrerojosh added Type: Documentation Improvements or additions to documentation Type: Dependencies Pull requests that update a dependency file labels Feb 10, 2022
@ferrerojosh ferrerojosh pinned this issue Feb 10, 2022
@Toilal
Copy link
Contributor

Toilal commented Mar 11, 2022

I think the proper move would be to implement calling Keycloak's authorization API ourselves instead of relying on their official Node.js adapter.

Maybe this code should go in another standalone repo without nest dependencies ? This could also implement a passport strategy, as passport is the recommanded way to bring authentication in NestJS (according to official docs).

@SebastianSchenk
Copy link

According to the official deprecation announcement, openid-client seams to be the recommended library for nodejs. Maybe it makes sense to use this as the underlying library.

@ferrerojosh
Copy link
Owner

We could probably migrate most parts to openid-client but it could not be said the same for Keycloak's authorization services.

@Toilal
Copy link
Contributor

Toilal commented Jan 7, 2023

I just released a very first version of an OpenID Connect passport strategy here.

It is tested against keycloak and can replace the JWT Token verification of official (and deprecated) keycloak node.js adapter.

I plan to add more packages in this repository with a single objective in mind for now : have the same features as nest-keycloak-connect, but without relying on keycloak-connect deprecated package.

@MarcosPauloSouzaMiranda
Copy link

Hello,

Are there any upgrade expectations to address the deprecated library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Pull requests that update a dependency file Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants