Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error #1009 on Scroller/focusOutHandler #1808

Open
cgascons opened this issue Jan 7, 2021 · 2 comments
Open

Error #1009 on Scroller/focusOutHandler #1808

cgascons opened this issue Jan 7, 2021 · 2 comments

Comments

@cgascons
Copy link

cgascons commented Jan 7, 2021

Hi, we are getting quite a few of these. This is the stack trace we were able to track from our players:

TypeError: Error #1009
at feathers.controls::Scroller/focusOutHandler()
at starling.events::EventDispatcher/invokeEvent()
at starling.events::EventDispatcher/dispatchEvent()
at starling.display::DisplayObject/dispatchEvent()
at starling.events::EventDispatcher/dispatchEventWith()
at feathers.core::DefaultFocusManager/set focus()
at feathers.core::DefaultFocusManager/topLevelContainer_touchHandler()
at starling.events::EventDispatcher/invokeEvent()
at starling.events::TouchEvent/dispatch()
at starling.events::Touch/dispatchEvent()
at starling.events::TouchProcessor/processTouches()
at starling.events::TouchProcessor/advanceTime()
at starling.core::Starling/advanceTime()
at starling.core::Starling/nextFrame()
at starling.core::Starling/onEnterFrame()

I'm not quite sure on how to replicate it, according to your code, Scroller's focusOutHandler function is quite simple and I believe only the fact that the player doesn't have a valid Stage would be able to cause this issue, right? Is there any way a safe check can be added here to avoid this issue?

@joshtynjala
Copy link
Member

While you could add a check if the stage is null, it means that those listeners will not be removed. Luckily, I added those listeners as a weak reference, so it shouldn't cause a memory leak. Still, it's concerning. What you describe should not happen.

@cgascons
Copy link
Author

cgascons commented Jan 8, 2021

I understand, it's definitely weird. This started happening since I last updated Feathers to the latest version, the previous version I had was: 3.1.2, I know, it was quite old so I took the chance and updated both Starling and Feathers to their latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants