Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Charge Stance properly #1

Open
fatcerberus opened this issue Mar 2, 2017 · 1 comment
Open

Implement Charge Stance properly #1

fatcerberus opened this issue Mar 2, 2017 · 1 comment

Comments

@fatcerberus
Copy link
Owner

Charge Stance was implemented very lazily; it just takes the first action of Charge Slash and prepends that to the selected move's actions. This causes the turn preview to be incorrect and requires the engine to modify the skill data prior to queuing actions, which may have other unforeseen issues.

Ideally, the Charge turn should be implemented as a basic action in the battle engine, tied to the Stance. Modifying skill data on-the-fly outside of a status or field condition is tacky so it would be best to avoid any solution involving such manipulation.

@fatcerberus
Copy link
Owner Author

I'm actually not sure how the move data manipulation interacts with statuses. I'll need to check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant