Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For reviewing my code #1

Open
far1dghaderi opened this issue Aug 3, 2021 · 2 comments
Open

For reviewing my code #1

far1dghaderi opened this issue Aug 3, 2021 · 2 comments

Comments

@far1dghaderi
Copy link
Owner

If there was anything to edit or adding to the project, you can use this issue to do that

@far1dghaderi
Copy link
Owner Author

far1dghaderi commented Aug 4, 2021 via email

@AhmadRajabi
Copy link

AhmadRajabi commented Aug 5, 2021

من بصورت اجمالی نگاه کردم و با اجازه، چند تا نکته به نظرم رسید:
1- سعی کنید app.js همیشه خلوت باشه. مثلا خط های 25-18 و 66-43 میتونه توی
یه فایل جدا باشه و در app.js فقط import کنید.
2-از naming convention https://github.com/felixge/node-style-guideهای
nodejs تبعیت بشه بهتره.(نام فایل ها و فولدرها بعضی با حروف بزرگ شروع شدن و
بعضی با حروف کوچک )
3- validation های سمت سرور حیاتی هستن و حتما باید باشن. (مثلا
express-validator https://www.npmjs.com/package/express-validator)

یکی از نقاط قوت کدها استفاده از async و await هست.
موفق باشی

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants