Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MPI utils #91

Open
1 of 2 tasks
fankiat opened this issue Nov 29, 2022 · 0 comments
Open
1 of 2 tasks

Refactor MPI utils #91

fankiat opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request prio:low Low priority

Comments

@fankiat
Copy link
Owner

fankiat commented Nov 29, 2022

Currently, we have separate files with separate classes for 2D and 3D MPI utils features. This can be generalized into dimension-agnostic code, so that users will not have to worry about the dimension of the MPIConstruct they are initializing, rather it will be inferred from the grid_size prescribed by the user.

I'm still not fully sure if we will benefit from this, and will see as we go when developing the 3D simulator. I'm putting this as low priority for now.

Things that need refactoring:

@fankiat fankiat added enhancement New feature or request prio:high High priority labels Nov 29, 2022
@fankiat fankiat self-assigned this Nov 29, 2022
@fankiat fankiat added prio:medium Medium priority and removed prio:high High priority labels Nov 29, 2022
@fankiat fankiat changed the title Generalized MPI utils Refactor MPI utils Nov 29, 2022
@fankiat fankiat added prio:low Low priority and removed prio:medium Medium priority labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant