Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Ctrl-C while a program loads make the program hang #78

Open
fachat opened this issue Feb 24, 2024 · 3 comments
Open

Pressing Ctrl-C while a program loads make the program hang #78

fachat opened this issue Feb 24, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@fachat
Copy link
Owner

fachat commented Feb 24, 2024

After implementing #29 , when pressing Ctrl-C (RUN/STOP) while the loader is loading the file to be executed, terminates the loader, but does not free the SENDBUF PSEM.
This makes the system hang on each function that uses SENDBUF

@fachat fachat added this to the 2.2 milestone Feb 24, 2024
@fachat
Copy link
Owner Author

fachat commented Feb 24, 2024

This should automatically be fixed when implementing the new buffer / streams handling in NG - so won't fix here.

@fachat fachat added bug Something isn't working wontfix This will not be worked on labels Mar 1, 2024
@fachat fachat removed this from the 2.2 milestone Mar 1, 2024
@fachat
Copy link
Owner Author

fachat commented Mar 8, 2024

Addition: similar problems appear when the child process is suspended (e.g. via Ctrl-Z) while still in the loading process.

@fachat
Copy link
Owner Author

fachat commented Mar 8, 2024

Implementation idea for NG buffer/send/receive:

  • alloc a new buffer for stream
  • put everything to be sent into buffer
  • send buffer non-blocking
  • register stream and buffer with the child task registry
  • wait for reply from child, but check signals at that same time
  • if signal received, return
  • handle any checks in further waitpid/checksig calls

Note: need to check for race conditions.

@fachat fachat removed the wontfix This will not be worked on label Mar 12, 2024
@fachat fachat added this to the 2.3 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant