Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with argparse in PyTorch Lightning v2 #322

Open
stperrakis opened this issue Oct 11, 2023 · 1 comment
Open

Issue with argparse in PyTorch Lightning v2 #322

stperrakis opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@stperrakis
Copy link

Hello,

I've been updating the code in line with the changes introduced in PyTorch Lightning v2's documentation. I'm working to ensure that all modifications align correctly and the code functions as intended.

Once I've finalized the changes, would you be open to a pull request?

Thank you.

@stperrakis stperrakis added the enhancement New feature or request label Oct 11, 2023
@mmuckley
Copy link
Contributor

Hello @stperrakis

Oh yes, definitely open to a pull request! Primary thing is that it needs to conform to the formatting standards and behaviors of the existing repository so that users familiar with the old code need to change as little as possible (or ideally, don't need to change anything).

@mmuckley mmuckley added bug Something isn't working and removed enhancement New feature or request labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants