Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment syntax from ReactNativeTypes #31457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huntie
Copy link
Member

@huntie huntie commented Nov 8, 2024

Summary

I'm working to get the main react-native package parsable by modern Flow tooling (both flow-bundler, flow-api-translator).

This diff trivially removes some redundant Flow comment syntax in ReactNativeTypes.js, which fixes parsing under these newer tools.

How did you test this change?

Files were pasted into react-native-github under fbsource, where Flow validates ✅.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:41am

@react-sizebot
Copy link

react-sizebot commented Nov 8, 2024

Comparing: c11c951...9b1c127

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.94 kB 509.94 kB = 91.24 kB 91.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.88 kB 514.88 kB = 91.95 kB 91.95 kB
facebook-www/ReactDOM-prod.classic.js = 594.80 kB 594.80 kB = 104.96 kB 104.96 kB
facebook-www/ReactDOM-prod.modern.js = 585.07 kB 585.07 kB = 103.39 kB 103.39 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/shims/ReactNativeTypes.js = 8.41 kB 8.32 kB = 2.22 kB 2.19 kB

Generated by 🚫 dangerJS against 571b688

@huntie
Copy link
Member Author

huntie commented Nov 8, 2024

V2: Address Prettier and ESLint errors on touched file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants