footer positioning fix

fablabbcn · Oct 31, 2024 · c4f88a6 · c4f88a6
1 parent 10d149c
commit c4f88a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/app/assets/stylesheets/footer.scss b/app/assets/stylesheets/footer.scss
@@ -1,7 +1,5 @@
 footer {
   width: 100%;
-  position: absolute;
-  bottom: -8px; /* I have no idea why this negative offset is needed here, nothing has any margin or anything */
   a {
     color: $primary;
     &:hover {

diff --git a/app/assets/stylesheets/global.scss b/app/assets/stylesheets/global.scss
@@ -8,9 +8,17 @@ body{
   background-image: image-url("sck_bg.png");
   background-repeat: repeat;
   background-size: 65px;
-  height: 100vh;
+  min-height: 100vh;
+  height: 100%;
+  display: flex;
+  flex-direction: column;
 }
 
+body > .container {
+  flex-grow: 1;
+}
+
+
 .border-thick {
   border-width: 3px !important;
 }