Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coding #41

Open
fa201 opened this issue May 1, 2021 · 0 comments
Open

Improve coding #41

fa201 opened this issue May 1, 2021 · 0 comments
Labels
code Better code practice

Comments

@fa201
Copy link
Owner

fa201 commented May 1, 2021

  • better comment the code (why, how)
  • better split or merge functions
  • use os.path.join() for file path
  • use entry.state(['disabled']) instead of state='disabled' (deprecated).
  • https://codereview.stackexchange.com/questions/239821/simple-gui-unit-converter-with-tkinter. Separate widget creation and widget positioning
  • Do not create variable for labels except if label should be updated by a StringVar
  • Initialize StringVar with the actual value (value='blabla'). Avoid using set
  • String concatenation must be done with ''.join(list_of_strings)
@fa201 fa201 added the code Better code practice label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Better code practice
Projects
None yet
Development

No branches or pull requests

1 participant