Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent types in tendermint RPC #92

Open
IvantheTricourne opened this issue Nov 7, 2019 · 3 comments
Open

Inconsistent types in tendermint RPC #92

IvantheTricourne opened this issue Nov 7, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@IvantheTricourne
Copy link
Contributor

IvantheTricourne commented Nov 7, 2019

Related to #75.

Missing Fields

Type definitions with fields that are missing when uninitialized

  • Info: last_block_height and last_block_app_hash

Null Fields

Type definitions with fields that are set to null when uninitialized

String Fields

Type definitions with fields typed "string" (i.e., wrappers over number types)

Client.hs

Response.hs

Request.hs

FieldTypes.hs

Types.hs

@martyall martyall changed the title Inconsistent types Inconsistent types in tendermint RPC Nov 18, 2019
@martyall martyall added the bug Something isn't working label Nov 18, 2019
@martyall
Copy link
Collaborator

related to #109

@alexfmpe
Copy link
Contributor

alexfmpe commented Apr 1, 2020

Edit: Ok, this was resolved by bumping kepler, so I think it can be ignored.

I'm running into

*** Exception: ParsingException "parsing Word64 failed, expected Number, but encountered String"

when trying to use RPC.abciInfo even though manually curling works

{
  "jsonrpc": "2.0",
  "id": "",
  "result": {
    "response": {
      "data": "1",
      "version": "123",
      "app_version": "1",
      "last_block_height": "123"
    }
  }
}

I see this was erroring as of 92b3b4c.

I'm currently depending on an older version than that, and was wondering if bumping Kepler would fix this.

It seems to work in current Travis? https://travis-ci.com/github/f-o-a-m/kepler/jobs/310896828

RPC Request
{
    "jsonrpc": "2.0",
    "params": [],
    "method": "abci_info",
    "id": 2149148217020253723
}
RPC Response
{
    "result": {
        "response": {
            "data": "{\"size\":0}",
            "app_version": "1",
            "version": "0.16.1"
        }
    },
    "jsonrpc": "2.0",
    "id": 2149148217020253696
}
    Can query /abci_info and parse the result

@martyall
Copy link
Collaborator

martyall commented Apr 3, 2020

Yeah this kind of stuff was always a pain to get right, we only lazily discover these kinds of errors. Let me know if you're problem wasn't actually fixed by the bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants