Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature annotation #7

Open
wants to merge 2 commits into
base: feature_login
Choose a base branch
from
Open

Feature annotation #7

wants to merge 2 commits into from

Conversation

CUCU7103
Copy link
Collaborator

πŸ“Œ PR 제λͺ©

  • μ–΄λ…Έν…Œμ΄μ…˜μ— 주석 μΆ”κ°€ 및 기타 μˆ˜μ •

πŸš€ λ³€κ²½ 사항 (Changes)

  • μ‚¬μš©ν•œ μ–΄λ…Έν…Œμ΄μ…˜μ— λŒ€ν•΄μ„œ μ£Όμ„μœΌλ‘œ μ„€λͺ…μΆ”κ°€
  • p6spy 디렉토리 λ³€κ²½
  • λΆˆν•„μš”ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œ 클래슀 μ‚­μ œ

πŸ’₯ κ΄€λ ¨ 이슈 (Related Issues)

πŸ’¬ 리뷰 μš”κ΅¬μ‚¬ν•­

🚴 체크리슀트 (Checklist)

  • else ν‚€μ›Œλ“œ μ‚¬μš©ν•˜μ§€ μ•ŠκΈ°
  • getter/setter/propertyλ₯Ό 쓰지 μ•ŠκΈ°
  • ν•œ 쀄에 점을 ν•˜λ‚˜λ§Œ 찍기 (λ””λ―Έν„°μ˜ 법칙)
  • ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±μ—¬λΆ€
  • 넀이버 μ½”λ“œ μ»¨λ²€μ…˜ μ€€μˆ˜μ—¬λΆ€

@CU7103
Chore: μ–΄λ…Έν…Œμ΄μ…˜ μ„€λͺ…
53bae7a 
μ–΄λ…Έν…Œμ΄μ…˜μ— λŒ€ν•œ μ„€λͺ…을 μ£Όμ„μœΌλ‘œ 좔가함
@CU7103
Chore: 디렉토리 λ³€κ²½ 및 μ½”λ“œ μ‚­μ œ
1bf0da7 
p6spy 디렉터리 λ³€κ²½κ³Ό λΆˆν•„μš”ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œ μ‚­μ œ
@CUCU7103 CUCU7103 self-assigned this Nov 23, 2024
@f-lab-jd
Copy link
Collaborator

ν˜„μž¬ PR 에 이전 PR 에 올린 λ‚΄μš©λ„ 포함이 λ˜μ–΄μžˆμŠ΅λ‹ˆλ‹€.
λΆ„λ¦¬ν•΄μ„œ PR 을 λ‹€μ‹œ μ˜¬λ €μ£Όμ‹œκ±°λ‚˜, target branch λ₯Ό 이전 PR 브랜치둜 λ³€κ²½ν•΄μ„œ λ‹€μ‹œ μ˜¬λ €μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€.

@CUCU7103 CUCU7103 changed the base branch from develop to feature_login November 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-jd f-lab-jd Awaiting requested review from f-lab-jd

Assignees

@CUCU7103 CUCU7103

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CUCU7103 @f-lab-jd @CU7103