Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between bundles #270

Open
robertherber opened this issue Apr 16, 2024 · 0 comments
Open

Differentiate between bundles #270

robertherber opened this issue Apr 16, 2024 · 0 comments

Comments

@robertherber
Copy link

robertherber commented Apr 16, 2024

We're building one dev client which we use for multiple projects/bundles. We currently have 2 app bundles and one for storybooks, all using the same dev client and native code.

Currently - to make all bundles show up in the dev client (when navigating there) this requires the Expo project to be identical. But this also means the comments from expo-github-action are identical, resulting in 3 identical comments (even if the QR codes are pointing to different bundles).

I understand it might be complicated to accomodate for all use cases here. So what I'd suggest is just a simple way to add a custom comment/name of some kind to differentiate between different comments. Something like a "commentTitle" that can be sent as an additional parameter to the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant