Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job to GitHub work flow #295

Closed
ckunki opened this issue Jun 20, 2024 · 0 comments · Fixed by #296
Closed

Add job to GitHub work flow #295

ckunki opened this issue Jun 20, 2024 · 0 comments · Fixed by #296
Assignees
@ckunki
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jun 20, 2024 •
edited
Loading

The developers reported to have had been able to merge PR #290 without executing Jupyter Notebook Tests.

  • The PR reports this job to have been "skipped".
  • Branch protection is set up to require this job to terminate successfully before merging to main branch is allowed.

To improve the branch protection, the current ticket requests to

  • add a gate job
  • containing only a trivial action
  • make the gate job depend on all jobs that should be required before merging to main branch
  • use this gate job to configure branch protection in the settings of the GitHub repository

See job gate-2 in repo saas-api-python.
@ckunki ckunki added the refactoring Code improvement without behavior change label Jun 20, 2024
@ckunki ckunki self-assigned this Jun 24, 2024
ckunki added a commit that referenced this issue Jun 24, 2024
@ckunki
#295: Made notebook-tests mandatory for merge
98304ad
@ckunki ckunki mentioned this issue Jun 24, 2024
Merged
ckunki added a commit that referenced this issue Jun 24, 2024
@ckunki
Merge branch 'main' into refactoring/#295-Made_notebook-tests_mandato…
16d1cdb 
…ry_for_merge
This was referenced Jun 25, 2024
Open
Open
ckunki added a commit that referenced this issue Jun 27, 2024
@ckunki @tkilias
#295: Made notebook-tests mandatory for merge (#296)
d358a2e 
* #295: Made notebook-tests mandatory for merge
* Updated GitHub workflow files
* Moved shell check to check_ci.yaml
* Removed hyperlinks checking from regular ci build
* Sorted notebook files before running notebook tests
* Added log message for executing each single notebook test file
* #193: Ignored warnings in notebook tests
* Moved logging options to pytest.ini for notebook tests
* #297: Reduced log level for transitive libraries in notebook tests
* Reduce logging in all notebooks

Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckunki ckunki

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#295: Made notebook-tests mandatory for merge exasol/ai-lab
1 participant
@ckunki