Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

StdMod #43

Open
Freeaqingme opened this issue Oct 17, 2013 · 3 comments
Open

StdMod #43

Freeaqingme opened this issue Oct 17, 2013 · 3 comments

Comments

@Freeaqingme
Copy link

Hi Al,

I've begun porting this thing to the StdMod setup. I'd suggest cloning that repo, and simply push the branch develop of that repo to this repo. I preserved all Git history btw (of both the skeleton as well as this repo), so that should all be alright.

@alvagante
Copy link
Member

I'd just create and manage directly on stdmod the iptables module, as that's the typical general module than makes sense under the official stdmod hat.
On Example42 version 3 modules I would just use and point the stdmod/iptables and stdmod/firewall

On this matter anyway I've some concerns... puppetlabs-firewall module is widely used and I wonder if it wouldn't be saner just to stick to it and follow its patterns so that we don't introduce a dependency on a rather common feature.

Currently afaik , the Puppetlabs' firewall module has providers only for iptables, but since is based on a custom type (firewall) it can be extended with new providers.
I know that it's hard to throw away all our work on the firewall/iptables modules, but I really think that stdmod should be as much "upstream" as possible, and puppetlabs-firewall is the best candidate for being the "official" solution to firewall management.

What do you think?

@Freeaqingme
Copy link
Author

What do you think?

I think, for one, the timing sucks ;)

I'm all for using the upstream repos, but glancing over it, I think it's got only half the functionality our module supports. Of course we could propose all that functionality to Puppetlabs, but as long as it's on a voluntary basis I'm not sure if I'm motivated to do that.

@alvagante
Copy link
Member

Let's do this them , publish stdmod/iptables which has most of the features and doesn't have namespaces clashes and let's hold decisions on our firewall abstraction module, which is just complementary and not strictly necessary, then we'll see how things evolve and what others suggest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants