Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run ewasm-tests with geth+evmc+hera #349

Open
axic opened this issue Aug 21, 2018 · 6 comments
Open

CI: run ewasm-tests with geth+evmc+hera #349

axic opened this issue Aug 21, 2018 · 6 comments
Assignees

Comments

@axic
Copy link
Member

axic commented Aug 21, 2018

@gballet has pushed a branch to help running ewasm tests with geth: https://github.com/ewasm/go-ethereum/tree/wasm-testing

@chfast chfast self-assigned this Nov 26, 2018
@chfast chfast removed their assignment Nov 26, 2018
@chfast
Copy link
Collaborator

chfast commented Nov 26, 2018

Currently, this is not easily doable, because go-ethereum will run Byzantium state tests in EVM mode (EWASM is not enabled in this config) even if --vm.ewasm=hera.so is specified.
You can add a hack like proposed .EnableWagon but I don't want to maintain it.

@gballet
Copy link
Member

gballet commented Nov 26, 2018

for reference, @chfast's PR ethereum/go-ethereum#18084

@axic
Copy link
Member Author

axic commented Dec 4, 2018

@gballet @chfast I see the PR was merged, is it now possible to continue this work?

@chfast chfast self-assigned this Dec 4, 2018
@chfast
Copy link
Collaborator

chfast commented Dec 4, 2018

even if --vm.ewasm=hera.so is specified.

No.

@chfast
Copy link
Collaborator

chfast commented Dec 4, 2018

This hack allows to run EWASM state tests in geth: ewasm/go-ethereum#7.

@gballet
Copy link
Member

gballet commented Dec 7, 2018

Actually that's what the fork rules are for, check ewasm/go-ethereum#9 That should work now; I'm seeking to activate travis to check, but I seem to have insufficient permissions @axic.

@chfast chfast removed their assignment Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants